Skip to content

Improve audio mixing for singing along with synth#112

Merged
petersalomonsen merged 1 commit intomasterfrom
improve-screenrecorder-audio-mixing
Dec 20, 2025
Merged

Improve audio mixing for singing along with synth#112
petersalomonsen merged 1 commit intomasterfrom
improve-screenrecorder-audio-mixing

Conversation

@petersalomonsen
Copy link
Owner

Changes

This PR improves the screen recorder's audio mixing when recording vocals alongside a soft synth.

Problem

  • Microphone audio was getting lost when the synth output was loud or clipping
  • Microphone was mono only

Solution

  • Added compressor/limiter on synth: Prevents clipping from drowning out the microphone
    • Threshold: -6dB, Ratio: 12:1, Fast attack (0.003s)
  • Enabled stereo microphone input: channelCount: 2
  • Disabled audio processing: echoCancellation, noiseSuppression, and autoGainControl are disabled to preserve vocal quality and dynamics
  • Adjusted gain levels: Synth at 0.7, mic at 1.5 for better balance when singing along

- Add compressor/limiter on synth to prevent clipping from drowning out mic
- Enable stereo microphone input (channelCount: 2)
- Disable echoCancellation, noiseSuppression, autoGainControl for better vocal quality
- Adjust gain levels: synth at 0.7, mic at 1.5 for better balance
@petersalomonsen
Copy link
Owner Author

@race-of-sloths include

@race-of-sloths
Copy link

race-of-sloths commented Dec 20, 2025

@petersalomonsen Thank you for your contribution! Your pull request is now a part of the Race of Sloths!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@chatgpt-codex-connector[bot] 3

Your contribution is much appreciated with a final score of 3!
You have received 36 (30 base + 20% lifetime bonus) Sloth points for this contribution

@chatgpt-codex-connector[bot] received 25 Sloth Points for reviewing and scoring this pull request.

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@petersalomonsen
Copy link
Owner Author

@codex Please score my PR according to the following criteria:

0/exclude - comma fix, trivial with no added value
1 - small non-priority feature
2 - medium non-priority feature, small bug-fix
3 - small prioritized feature, bug-fix, major improvement
5 - medium prioritized feature, small security vulnerability fix, a time-consuming trivial task
8 - critical feature, medium vulnerability fix
13 - significant vulnerability fix, game-changer contribution

Reply with only this message: @race-of-sloths score N

where N is the score you find appropriate for what's done here.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@petersalomonsen
Copy link
Owner Author

@codex can you score now based on the criteria from https://race-of-sloths.com/faq?

Only respond with a message that says @race-of-sloths score N

where N Is a number according to the scoring criterias

0/exclude - comma fix, trivial with no added value
1 - small non-priority feature
2 - medium non-priority feature, small bug-fix
3 - small prioritized feature, bug-fix, major improvement
5 - medium prioritized feature, small security vulnerability fix, a time-consuming trivial task
8 - critical feature, medium vulnerability fix
13 - significant vulnerability fix, game-changer contribution

@chatgpt-codex-connector
Copy link

@race-of-sloths score 3

View task →

@petersalomonsen petersalomonsen merged commit 4ab4715 into master Dec 20, 2025
6 checks passed
@petersalomonsen petersalomonsen deleted the improve-screenrecorder-audio-mixing branch December 20, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants