Merges code of three gems into one #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rubendebest
commented
Jan 12, 2025
rubendebest
commented
- Adds all code and tests from aws-sns-configurator to turtle;
- Adds all code and tests from aws-sqs-configurator to turtle;
- Removes turtle's dependencies from the above gems.
rubendebest
force-pushed
the
internalize-sns-sqs
branch
from
5dbca35 to
2c75120
Compare
- Adds all code and tests from aws-sns-configurator to turtle; - Adds all code and tests from aws-sqs-configurator to turtle; - Removes turtle's dependencies from the above gems.
rubendebest
force-pushed
the
internalize-sns-sqs
branch
from
2c75120 to
82fa63e
Compare
rubendebest
commented
Jan 13, 2025
Comment on lines
+27
to
+29
| config.after(:each) do | ||
| ENV['AWS_REGION'] = nil | ||
| end |
Contributor
Author
There was a problem hiding this comment.
Necessário pois sem isso os testes quebram dependendo do seed utilizado.
ferreiraandy
approved these changes
Jan 13, 2025
alipio
approved these changes
Jan 13, 2025
rhiroyuki
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.