refactor-main

[petrubraha]

Features

• reactor
• multiplexer
• reactor_proxy (old reactor_client)
• app

The goal is to disable core.IS_CLI checks and assertions (e.g. page is not None).

IS_CLI spots:

• main
• reactor.init - dict[Connection, Chat]
• reactor_client.bind_chat
• multiplexing.cond_render - page.run_task

Workflow

These scripts trigger their corresponding init_* method. The init_* steps:

• create Page (if GUI mode)

• create Reactor

• create ReactorProxy

• create App

• pass app shutdown to page.on_close()

• call main.py (bin/run.sh)

• call

class AppCli:
  __init__(reactor_proxy)
  add_conn(conn_data)
  rem_conn(conn)
  shutdown()

class AppGui(CliApp):
  __init__(reactor_proxy, layout)
  add_conn(conn_data)
  rem_conn(conn)
  shutdown() - awaits page.destroy

Changes to be made:

• rename core -> util
• create init_cli, init_gui
• create main_cli.py - creates a ReactorCli, ReactorProxyCli, AppCli
• create main_gui.py - creates a ReactorGui, ReactorProxyGui, AppGui

Directory structure:

core/
  reactor/
    reactor_cli
    reactor_gui
  reactor_proxy/
    reactor_proxy_cli
    reactor_proxy_gui
  app/
    app_cli
    app_gui
  init_workflow

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

• 🔍 Trigger a full review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch refactor-main

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[petrubraha]

unit tests?

[petrubraha]

Name                                                Stmts   Miss  Cover   Missing
---------------------------------------------------------------------------------
src\main.py                                            39     39     0%   1-57
src\multiplexing.py                                    84     84     0%   7-183
src\network\connection.py                              17      1    94%   35
src\reactor.py                                         75     70     7%   20-185
src\transmission\handle_read.py                        25     25     0%   1-61
src\transmission\handle_write.py                       41     41     0%   1-82
src\transmission\processor.py                          45     45     0%   1-115