libs/base/idlesrc: cleanup & add support for shared thread pool #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing DTX generation in decoders, they are indeed producing buffers without having a corresponding input buffer, so this code needs to be revisited, and perhaps need a special method for pushing buffers like this? https://bugzilla.gnome.org/show_bug.cgi?id=773106
…eo alignment requirements" [pexhack] This reverts commit 8b96b52.
…and use duration 0"" [pexhack] This reverts commit b60ab75. https://bugzilla.gnome.org/show_bug.cgi?id=754224
Depayloaders should be less strict about spec conformance on incoming packets.
With this patch pexip/mcu@f819d92 @johnbassett discovered that old frames would be produced if stopping and starting a layer. However, setting drop-only always to true means we can never increase the framerate making the caps negotiation fail. This hack sets drop-only to true when the input rate is higher or equal to the output one. A proper fix would be to identify the bug @johnbassett discovered and do a test and fix for that in the videorate element.
…f frame" This is because we set this flag ourselves in the implementations. This reverts commit 7013a58.
A way to embed ROI meta in the RTP extension header.
...and deal with non-modulo 4 padding bytes for non-standard RTCP. This is thanks to Chrome sending these packets to us when doing TWCC. Whereas the standard says that non-modulo 4 bytes padding are not allowed, for reduced size and TWCC in particular, this does not seem to apply. In order to be able to safely parse FCIs from these packets, a new API is proposed: gst_rtcp_packet_fb_get_fci_length_bytes, that will respect the non-mod4 padding and subtract that from the valid FCI length. Co-Authored-By: Tulio Beloqui <tulio.beloqui@pexip.com> Co-Authored-By: John-Mark Bell <jmb@pexip.com>
We don't always want the PTS of the frame to be updated. The default value is kept TRUE to comply with the previous behaviour. Co-Authored-By: Håvard Graff <hgr@pexip.com>
Basically, don't set a DISCONT flag when detecting a seqnum jump. This is useful for ULPFEC, as a FEC packet might be hiding inside the original stream, and this stream is actually completely valid, even if the FEC packet is removed.
Also introducing a test-suite for speex. https://bugzilla.gnome.org/show_bug.cgi?id=754226
Don't send a segment event if we haven't produced data and set the output caps yet. Doing so causes a g_warning about sticky event misordering. https://bugzilla.gnome.org/show_bug.cgi?id=773510
Allows it to be configured differently for different use-cases, specifically the live scenario would probably never want this enabled. https://bugzilla.gnome.org/show_bug.cgi?id=773511
This is a Pexip specific change since we are only interested in using gstflvdemux live.
This happens all the time for us, so no point warning about it.
Multiple SIMD-ified vpx plugins will be built if available. These plugins will be put in a separate plugin directory which can be linked to if configuring with --enable-simd-symlink=avx etc.
camilo-celis
force-pushed
the
camilo/baseidlesrc-fixups
branch
from
2306a5e to
3cd6a34
Compare
Similar to the basesrc, buffer allocation could be a featured that is implemented on derived classes
Buffer allocation, and pushing is driven by derived classes Remove up until we have an use for it
camilo-celis
force-pushed
the
camilo/baseidlesrc-fixups
branch
from
3cd6a34 to
af6d75d
Compare
camilo-celis
force-pushed
the
camilo/baseidlesrc-fixups
branch
from
af6d75d to
d72b517
Compare
camilo-celis
changed the title
camilo-celis
commented
Oct 30, 2025
camilo-celis
force-pushed
the
camilo/baseidlesrc-fixups
branch
from
bb611d6 to
e98b8a4
Compare
this is just now introduced so no need to add a version to it
This pool could be owned externally, and this is only useful for tests anyways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.