-
Notifications
You must be signed in to change notification settings - Fork 0
Feature Library #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Streus
wants to merge
7
commits into
master
Choose a base branch
from
streus/feature-lib
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature Library #19
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
741807a
Started work on FeatureLibrary
Streus c18ff6f
Checkpoint because running this code could break things...
Streus 48975b8
Working prototype. Generated names aren't working properly.
Streus b9e9b8a
Tweaks and polish to FeatureLibrary creating and refreshing. Created …
Streus 0b8ebe1
Cleaned up inspector GUI. Ditched auto-refresh, at least for now.
Streus 764d9e2
Fixed FeatureLibrary refresh, hopefully
Streus cfa2dbf
Fixed w/o the hack
Streus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| using UnityEngine; | ||
| using UnityEditor; | ||
| using UnityEditor.AnimatedValues; | ||
|
|
||
| namespace Labrys.Editor | ||
| { | ||
| [CustomEditor(typeof(FeatureLibrary))] | ||
| public class FeatureLibraryInspector : UnityEditor.Editor | ||
| { | ||
| private AnimBool fadeGroupVal = new AnimBool(false); | ||
|
|
||
| public void OnEnable() | ||
| { | ||
| fadeGroupVal.valueChanged.AddListener(Repaint); | ||
| } | ||
|
|
||
| public override void OnInspectorGUI() | ||
| { | ||
| serializedObject.UpdateIfRequiredOrScript(); | ||
| FeatureLibrary library = (FeatureLibrary)serializedObject.targetObject; | ||
|
|
||
| EditorGUILayout.SelectableLabel(library.TargetDirectory); | ||
|
|
||
| if (GUILayout.Button("Refresh")) | ||
| { | ||
| Undo.RegisterCompleteObjectUndo(library, "Feature Library Refresh"); | ||
| library.Refresh(); | ||
| EditorUtility.SetDirty(library); | ||
| } | ||
|
|
||
| GUILayout.Space(25); | ||
| if (GUILayout.Button(fadeGroupVal.value ? "Hide contents" : "Show contents")) | ||
| fadeGroupVal.target = !fadeGroupVal.value; | ||
| if (EditorGUILayout.BeginFadeGroup(fadeGroupVal.faded)) | ||
| { | ||
| foreach (FeatureLibrary.Entry entry in library) | ||
| { | ||
| EditorGUILayout.BeginHorizontal(); | ||
| Debug.Log($"{entry.FaID}: {entry.Name}"); | ||
| EditorGUILayout.SelectableLabel($"{entry.FaID}: {entry.Name}", GUILayout.Height(20)); | ||
| if (GUILayout.Button("-->")) | ||
| { | ||
| ProjectWindowUtil.ShowCreatedAsset(entry.Feature); | ||
| } | ||
| EditorGUILayout.EndHorizontal(); | ||
| } | ||
| } | ||
| EditorGUILayout.EndFadeGroup(); | ||
| } | ||
| } | ||
| } | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. newline at end of file |
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have a rule for always using braces? /nitpick