feat: add migrate package #247
Open
+809
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jason-lynch
force-pushed
the
feat/PLAT-347/election-pkg
branch
from
448017e to
847d42a
Compare
jason-lynch
force-pushed
the
feat/PLAT-347/migrations
branch
from
64e7057 to
24aad70
Compare
jason-lynch
force-pushed
the
feat/PLAT-347/election-pkg
branch
from
847d42a to
9238c9f
Compare
jason-lynch
force-pushed
the
feat/PLAT-347/migrations
branch
from
24aad70 to
8b2d7e1
Compare
jason-lynch
force-pushed
the
feat/PLAT-347/election-pkg
branch
from
9238c9f to
295b6d9
Compare
Adds a `migrate` package with a mechanism to run an ordered set of migrations on startup, such as Etcd data migrations. The migrations runner uses the `election` package to ensure that only one server instance is running the migrations at a time. Other instances will block startup until the migrations are complete, so we should aim to keep migrations as lightweight as possible. As stated in the package documentation, these migrations should be idempotent and, where possible, non-destructive. PLAT-347
jason-lynch
force-pushed
the
feat/PLAT-347/migrations
branch
from
8b2d7e1 to
278a4cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
migratepackage with a mechanism to run an ordered set of migrations on startup, such as Etcd data migrations. The migrations runner uses theelectionpackage to ensure that only one server instance is running the migrations at a time. Other instances will block startup until the migrations are complete, so we should aim to keep migrations as lightweight as possible. As stated in the package documentation, these migrations should be idempotent and, where possible, non-destructive.Testing
This PR does not add any migrations, so there are no functional changes. You should see a log message
control-plane db is up to date, no migrations to runfrom one of the hosts.PLAT-347