Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion api/apiv1/design/host.go
Original file line number Diff line number Diff line change
Expand Up @@ -253,9 +253,12 @@ var ListHostsResponseExample = map[string]any{
}

var RemoveHostResponse = g.Type("RemoveHostResponse", func() {
g.Attribute("task", Task, func() {
g.Description("The task that tracks the overall host removal operation.")
})
g.Attribute("update_database_tasks", g.ArrayOf(Task), func() {
g.Description("The tasks that will update databases affected by the host removal.")
})

g.Required("update_database_tasks")
g.Required("task", "update_database_tasks")
})
2 changes: 2 additions & 0 deletions api/apiv1/gen/control_plane/service.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions api/apiv1/gen/http/control_plane/client/types.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions api/apiv1/gen/http/control_plane/server/types.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions api/apiv1/gen/http/openapi.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 13 additions & 0 deletions api/apiv1/gen/http/openapi.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 24 additions & 0 deletions api/apiv1/gen/http/openapi3.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 21 additions & 0 deletions api/apiv1/gen/http/openapi3.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions changes/unreleased/Changed-20260114-163406.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
kind: Changed
body: The `remove-host` API response now includes a `task` that tracks the progress of the entire remove host operation.
time: 2026-01-14T16:34:06.805619-05:00
11 changes: 9 additions & 2 deletions clustertest/cluster_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,15 @@ func (c *Cluster) Remove(t testing.TB, hostID string) {
HostID: controlplane.Identifier(hostID),
})
require.NoError(t, err)
require.NotNil(t, resp, "RemoveHost response should not be nil")
require.NotNil(t, resp.UpdateDatabaseTasks, "UpdateDatabaseTasks should always be present (empty slice if no databases)")
require.NotNil(t, resp)
require.NotNil(t, resp.Task)
require.NotNil(t, resp.UpdateDatabaseTasks)

_, err = c.client.WaitForHostTask(t.Context(), &controlplane.GetHostTaskPayload{
HostID: controlplane.Identifier(hostID),
TaskID: resp.Task.TaskID,
})
require.NoError(t, err)

delete(c.hosts, hostID)
c.client = hostsClient(t, c.hosts)
Expand Down
48 changes: 15 additions & 33 deletions server/internal/api/apiv1/post_init_handlers.go
Original file line number Diff line number Diff line change
Expand Up @@ -200,23 +200,19 @@ func (s *PostInitHandlers) RemoveHost(ctx context.Context, req *api.RemoveHostPa
return nil, apiErr(err)
}

updateDatabaseInputs, err := s.prepareDatabaseUpdates(ctx, hostID, dbs)
specs, err := s.prepareDatabaseUpdates(ctx, hostID, dbs)
if err != nil {
return nil, err
}

input := &workflows.RemoveHostInput{
HostID: hostID,
UpdateDatabaseInputs: updateDatabaseInputs,
return nil, apiErr(err)
}

dbTasks, err := s.workflowSvc.RemoveHost(ctx, input)
output, err := s.workflowSvc.RemoveHost(ctx, hostID, specs...)
if err != nil {
return nil, apiErr(err)
}

return &api.RemoveHostResponse{
UpdateDatabaseTasks: tasksToAPI(dbTasks),
Task: taskToAPI(output.Task),
UpdateDatabaseTasks: tasksToAPI(output.DatabaseTasks),
}, nil
}

Expand Down Expand Up @@ -248,36 +244,22 @@ func (s *PostInitHandlers) validateHostRemoval(ctx context.Context, hostID strin
}

// prepareDatabaseUpdates prepares workflow inputs for all databases affected by host removal.
func (s *PostInitHandlers) prepareDatabaseUpdates(ctx context.Context, hostID string, dbs []*database.Database) ([]*workflows.UpdateDatabaseInput, error) {
updateInputs := make([]*workflows.UpdateDatabaseInput, 0, len(dbs))

func (s *PostInitHandlers) prepareDatabaseUpdates(ctx context.Context, hostID string, dbs []*database.Database) ([]*database.Spec, error) {
specs := make([]*database.Spec, 0, len(dbs))
for _, db := range dbs {
if err := s.updateDatabaseForHostRemoval(ctx, db, hostID); err != nil {
return nil, err
if ok := db.Spec.RemoveHost(hostID); !ok {
return nil, fmt.Errorf("%s host id not found/removed", hostID)
}

updateInputs = append(updateInputs, &workflows.UpdateDatabaseInput{
Spec: db.Spec,
ForceUpdate: false,
RemoveHosts: []string{hostID},
})
}

return updateInputs, nil
}
_, err := s.dbSvc.UpdateDatabase(ctx, database.DatabaseStateModifying, db.Spec)
if err != nil {
return nil, fmt.Errorf("failed to update database: %w", err)
}

// updateDatabaseForHostRemoval removes the host from a database spec and updates the database state.
func (s *PostInitHandlers) updateDatabaseForHostRemoval(ctx context.Context, db *database.Database, hostID string) error {
if ok := db.Spec.RemoveHost(hostID); !ok {
return apiErr(fmt.Errorf("%s host id not found/removed", hostID))
specs = append(specs, db.Spec)
}

_, err := s.dbSvc.UpdateDatabase(ctx, database.DatabaseStateModifying, db.Spec)
if err != nil {
return apiErr(err)
}

return nil
return specs, nil
}

// ListDatabases fetches all databases from the database service and converts them to API format.
Expand Down
Loading