Fix pg_upgrade (Spoc-291) #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Arrange regression tests to improve stability. - Add a basic TAP test that holds up the lolor behaviour in case of a dynamically loaded library.
The extension substitutes LO-related routines in pg_catalog with its own versions. As a result, pg_upgrade gets stuck in a conflict between existing and extension-created database objects. Aside from replacing the 'prosrc' value in the pg_proc table, we can only introduce 'pre-' and 'post-' stages to the upgrade. By calling the 'lolor.disable()' routine, we restore the core functions to their original state. After the upgrade, we replace core functions again with lolor ones by calling lolor.enable(). The enable/disable machinery provides users with an additional benefit: they can easily switch between built-in and lolor LO storages, as demonstrated by TAP tests. Also, add TAP tests. Being here, check the extension upgrade as well.
On the extension DROP command, call the disable() routine instead of multiple SPI calls. Also, introduce the lolor.is_enabled UI function to ensure the user can identify the current state.
mason-sharp
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.