Skip to content

Fix pqxx cmake major version typos#325

Merged
sanak merged 1 commit intodevelopfrom
fix-typos-in-cmake
Jan 13, 2026
Merged

Fix pqxx cmake major version typos#325
sanak merged 1 commit intodevelopfrom
fix-typos-in-cmake

Conversation

@sanak
Copy link
Member

@sanak sanak commented Jan 12, 2026 •
edited by coderabbitai bot
Loading

Changes proposed in this pull request:

  • Fix pqxx cmake major version typos

@pgRouting/admins

Summary by CodeRabbit

  • Bug Fixes
    • Corrected version detection to properly extract and report library version information.

✏️ Tip: You can customize this high-level summary in your review settings.

@sanak sanak requested review from cvvergara and robe2 January 12, 2026 13:25
@sanak sanak self-assigned this Jan 12, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 12, 2026 •
edited
Loading

Walkthrough

This pull request corrects a variable naming typo in the CMake FindPQXX module, replacing all instances of PQXX_VERSION_MAYOR with the correct PQXX_VERSION_MAJOR throughout version extraction and status reporting logic.

Changes

Cohort / File(s) Summary
CMake Version Module Typo Fix
cmake/FindPQXX.cmake		 Corrects variable name from PQXX_VERSION_MAYOR to PQXX_VERSION_MAJOR in version parsing, status output, and cleanup operations (4 line changes)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A typo squashed with whisker-twitching glee,
MAYOR became MAJOR, as it ought to be!
CMake now speaks with proper English grace,
No more Spanish slips in this coding space! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title clearly and accurately describes the main change: fixing typos in CMake configuration related to pqxx major version naming (PQXX_VERSION_MAYOR → PQXX_VERSION_MAJOR).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot reviewed Jan 12, 2026
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
cmake/FindPQXX.cmake (1)

40-48: Typo fix from MAYOR→MAJOR looks correct; consider making the STATUS output conditional.
The rename is consistent (compose, print, unset). If this find-module runs frequently, the always-on message(STATUS ...) lines can be noisy; consider gating behind if (PQXX_FIND_QUIETLY) / an opt-in debug flag.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0c9f44f and a7d23e8.

📒 Files selected for processing (1)
  • cmake/FindPQXX.cmake
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (185)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (17, 3, Debug, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-22.04, gcc-latest)
  • GitHub Check: Ubuntu psql (18, 3, Debug, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (18, 3, Release, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (17, 3, Debug, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (13, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (13, 3, Release, ubuntu-22.04, gcc-latest)
  • GitHub Check: Ubuntu psql (16, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (16, 3, Release, ubuntu-22.04, gcc-latest)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-latest, gcc-latest)
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (18, 3, Debug, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-latest, gcc-latest)
  • GitHub Check: Ubuntu psql (18, 3, Release, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (14, 3, Release, ubuntu-latest, gcc-latest)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (17, 3, Debug, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-22.04, gcc-latest)
  • GitHub Check: Ubuntu psql (18, 3, Debug, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (18, 3, Release, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (17, 3, Debug, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (13, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (16, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (16, 3, Release, ubuntu-22.04, gcc-latest)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-latest, gcc-latest)
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (18, 3, Debug, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-latest, gcc-latest)
  • GitHub Check: Ubuntu psql (18, 3, Release, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (14, 3, Release, ubuntu-latest, gcc-latest)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (17, 3, Debug, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-22.04, gcc-latest)
  • GitHub Check: Ubuntu psql (18, 3, Debug, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (18, 3, Release, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (17, 3, Debug, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (13, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (16, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (16, 3, Release, ubuntu-22.04, gcc-latest)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-latest, gcc-latest)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (18, 3, Debug, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-latest, gcc-latest)
  • GitHub Check: Ubuntu psql (18, 3, Release, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (14, 3, Release, ubuntu-latest, gcc-latest)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (17, 3, Debug, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-22.04, gcc-latest)
  • GitHub Check: Ubuntu psql (18, 3, Debug, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (18, 3, Release, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (17, 3, Debug, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (13, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (16, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-latest, gcc-latest)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-22.04, gcc-latest)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (18, 3, Debug, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-latest, gcc-latest)
  • GitHub Check: Ubuntu psql (18, 3, Release, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (14, 3, Release, ubuntu-latest, gcc-latest)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (17, 3, Debug, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (18, 3, Debug, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (18, 3, Release, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (17, 3, Debug, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (13, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (16, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-latest, gcc-latest)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-22.04, gcc-latest)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (18, 3, Debug, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-latest, gcc-latest)
  • GitHub Check: Ubuntu psql (18, 3, Release, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (14, 3, Release, ubuntu-latest, gcc-latest)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (17, 3, Debug, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (18, 3, Debug, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (18, 3, Release, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (17, 3, Debug, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (13, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (16, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-latest, gcc-latest)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-22.04, gcc-latest)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (18, 3, Debug, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-latest, gcc-latest)
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-22.04, gcc-latest)
  • GitHub Check: Ubuntu psql (18, 3, Release, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (14, 3, Release, ubuntu-latest, gcc-latest)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (17, 3, Debug, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (18, 3, Debug, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (18, 3, Release, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (17, 3, Debug, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (13, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (16, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-latest, gcc-latest)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-22.04, gcc-latest)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (18, 3, Debug, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-latest, gcc-latest)
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-latest, gcc-latest)
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-22.04, gcc-latest)
  • GitHub Check: Ubuntu psql (18, 3, Release, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (14, 3, Release, ubuntu-latest, gcc-latest)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (17, 3, Debug, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (18, 3, Debug, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (18, 3, Release, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (17, 3, Debug, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (13, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-latest, gcc-latest)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-22.04, gcc-latest)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (18, 3, Debug, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-latest, gcc-latest)
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-22.04, gcc-latest)
  • GitHub Check: Ubuntu psql (18, 3, Release, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (14, 3, Release, ubuntu-latest, gcc-latest)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (17, 3, Debug, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (18, 3, Debug, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (18, 3, Release, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (17, 3, Debug, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (13, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-latest, gcc-latest)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-22.04, gcc-latest)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (16, 3, Release, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (18, 3, Debug, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-latest, gcc-latest)
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-22.04, gcc-latest)
  • GitHub Check: Ubuntu psql (14, 3, Release, ubuntu-latest, gcc-latest)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (18, 3, Debug, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (18, 3, Release, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (16, 3, Release, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (17, 3, Debug, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-22.04, clang)
  • GitHub Check: Ubuntu psql (13, 3, Release, ubuntu-latest, clang)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (13, 3, Debug, ubuntu-22.04, gcc-latest)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-22.04, g++-11)
  • GitHub Check: Ubuntu psql (16, 3, Release, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (18, 3, Debug, ubuntu-latest, g++-11)
  • GitHub Check: Ubuntu psql (15, 3, Release, ubuntu-latest, gcc-latest)
  • GitHub Check: Ubuntu psql (17, 3, Release, ubuntu-22.04, gcc-latest)
  • GitHub Check: Ubuntu psql (14, 3, Release, ubuntu-latest, gcc-latest)

@sanak sanak merged commit c93b8f3 into develop Jan 13, 2026
146 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@cvvergara cvvergara cvvergara approved these changes

@robe2 robe2 Awaiting requested review from robe2

Assignees

@sanak sanak

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sanak @cvvergara