Skip to content

Conversation

@sanak
Copy link
Member

@sanak sanak commented Jan 12, 2026

Changes proposed in this pull request:

  • Add Debian CI which is compatible with docker-pgrouting build

@pgRouting/admins

Summary by CodeRabbit

  • Chores
    • Added automated build workflow for Debian systems supporting PostgreSQL versions 14–18 and PostGIS versions 3.5–3.6.

✏️ Tip: You can customize this high-level summary in your review settings.

@sanak sanak self-assigned this Jan 12, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 12, 2026

Walkthrough

A new GitHub Actions workflow file is added to automate building Debian packages across multiple PostgreSQL (14–18) and PostGIS (3.5–3.6) version combinations using containerized builds with standard installation and compilation steps.

Changes

Cohort / File(s) Summary
CI/CD Workflow Addition
\.github/workflows/debian\.yml
New workflow file for automated Debian builds triggered manually or on push/pull requests; includes matrix strategy for PostgreSQL and PostGIS version combinations; runs in postgis/postgis containers; performs dependency installation via apt, CMake configuration, and parallel make build.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A workflow so fine, in Debian's design,
With versions galore, PostgreSQL and PostGIS to align,
In containers they build, parallel and fast,
From checkout to install, each matrix unsurpassed!
GitHub Actions now hops, building with glee,
Making packages for all—pure automation spree! 🚀

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding a Debian CI workflow that is compatible with docker-pgrouting builds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sanak sanak requested review from cvvergara and robe2 January 12, 2026 13:42
@sanak sanak marked this pull request as ready for review January 12, 2026 13:42
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
.github/workflows/debian.yml (4)

3-8: Misleading comment and consider adding branch filters.

The comment states "manually triggered workflow" but the workflow also triggers on push and pull_request events. Additionally, without branch filters, this will run on every push to any branch.

💡 Suggested improvement
-# manually triggered workflow
+# triggered on push/PR to main branches or manually

 on:
   workflow_dispatch:
   push:
+    branches:
+      - main
+      - develop
   pull_request:
+    branches:
+      - main
+      - develop

23-49: Consider simplifying the matrix definition.

The current matrix with extensive excludes effectively results in only 5 combinations: (18, 3.6), (17, 3.5), (16, 3.5), (15, 3.5), (14, 3.5). An explicit include-only approach may be clearer and easier to maintain.

💡 Alternative explicit matrix
    strategy:
      fail-fast: false
      matrix:
        include:
          - postgres: 18
            postgis: 3.6
            pqxx: '7.10'
          - postgres: 17
            postgis: 3.5
            pqxx: '6.4'
          - postgres: 16
            postgis: 3.5
            pqxx: '6.4'
          - postgres: 15
            postgis: 3.5
            pqxx: '6.4'
          - postgres: 14
            postgis: 3.5
            pqxx: '6.4'

71-81: Minor: Consider using working-directory and fix step name.

The step name "Configure compiler" is slightly misleading—it's configuring the CMake build system. Also, using the working-directory directive is cleaner than cd.

💡 Suggested improvement
-     - name: Configure compiler
+     - name: Configure build
       run: |
         mkdir build
         cd build
         cmake ..

      - name: Build
+       working-directory: build
        run: |
-         cd build
          make -j $(nproc)
          make install

57-69: Add DEBIAN_FRONTEND=noninteractive for defensive CI practices.

While the libpqxx package naming (libpqxx-6.4 and libpqxx-7.10) is already correct for Debian, setting DEBIAN_FRONTEND=noninteractive is a defensive best practice in CI/container environments to explicitly prevent any interactive prompts.

💡 Suggested improvement
      - name: Install dependencies
        run: |
+         export DEBIAN_FRONTEND=noninteractive
          apt update
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0c9f44f and a69f0df.

📒 Files selected for processing (1)
  • .github/workflows/debian.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (2)
.github/workflows/debian.yml (2)

11-16: LGTM!

Good practices: concurrency control prevents redundant parallel runs, and permissions follow the principle of least privilege with read-only access.


51-52: All postgis/postgis image tags used in the matrix are available on Docker Hub, including the PostgreSQL 18 combination (18-3.6). No action required.

@sanak sanak merged commit ecfcb16 into pgRouting:develop Jan 13, 2026
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants