Skip to content

Conversation

@chassing
Copy link

@chassing chassing commented Jan 13, 2026

Change summary

Add a py.typed to support mypy checks.

Skipping analyzing "clientele": module is installed, but missing library stubs or py.typed marker

Pull request tasks

The following have been completed for this task:

  • Code changes
  • Tests written
  • Documentation changes for new or changed features
  • Pre-review preparation
    • make test
    • make format
    • make ty
    • make generate-test-clients
      • Test clients have changed because a new feature was introduced
      • Test clients remain the same
  • Changelog updated
  • Contributors updated

Other information

Distributing type information

@phalt
Copy link
Owner

phalt commented Jan 13, 2026

@chassing great contribution, thank you! Do we need to do anything else to ensure it is bundled when running the build? We use uv, which I believe uses hatch.

@phalt
Copy link
Owner

phalt commented Jan 13, 2026

@chassing please also add your name to CONTRIBUTORS.md

@chassing
Copy link
Author

Do we need to do anything else to ensure it is bundled when running the build? We use uv, which I believe uses hatch.

I've tested it locally via [tool.uv.sources] (UV - Managing dependencies), and it worked without any additional configs in pyproject.toml

@phalt
Copy link
Owner

phalt commented Jan 13, 2026

Amazing, I'll try get this shipped today or tomorrow. Thank you :)

@chassing
Copy link
Author

chassing commented Jan 13, 2026

Amazing, I'll try get this shipped today or tomorrow. Thank you :)

Please hold. 😢

With mypy enabled, on the usage side, the missing result parameter must be ignored by mypy. Maybe this needs a mypy plugin 🤷

Missing positional argument "result" in call to "user_repos" of "GitHubConsumer"

@chassing chassing marked this pull request as draft January 13, 2026 14:09
@phalt
Copy link
Owner

phalt commented Jan 13, 2026

@chassing yes good point. Perhaps it does. This needs to be the same for both result and response - we should continue working on it in this branch.

@phalt
Copy link
Owner

phalt commented Jan 13, 2026

I have been doing some digging and I think this is solvable without a mypy plugin. It'll need some decorator magic. Leave it with me for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants