add macos setup script #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - **Ubuntu/Debian**: [setup.sh](./scripts/setup.sh) | ||
| - **macOS**: [setup-macos.sh](./scripts/setup-macos.sh) | ||
|
|
||
| ### macOS Setup Notes |
Contributor
There was a problem hiding this comment.
I don't it's nice to ask users to uninstall rust
|
|
||
| # Run template example | ||
| cd compiler-tests/template/ | ||
| PHANTOM_THREADS=$(sysctl -n hw.ncpu) PHANTOM_DEBUG=false PHANTOM_VERBOSE_TIMINGS=true cargo run --release |
Contributor
There was a problem hiding this comment.
By default, phantom detect no. of cores and uses them. So setting sysctl -n hw.ncpu is not required
Contributor
|
Thanks for the PR! As commented, I don't think it's a nice idea to ask users to uninstall rust. Question: did you come across any issues when running phantom on macos? If so, can you please let me us know? Perhaps it'll be better to amend the readme with instructions that directly address the issues instead of adding a new setup script. We have the ubuntu setup script for docker/server purposes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.