Separate SimpleOperation / StructuralOperation #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate the inheritance hierarchies of SimpleOperation / StructuralOperation. This makes "SimpleOperation" the root class for all operational nodes. The inheritance hierarchy for StructuralOperation is kept for the moment, eventually the "contents" of structural operations can be entirely disassociated. They should evolve into something that can carry information specific to the structure, particularly backend-specific customizations of structural nodes.
caleridas
force-pushed
the
separation-operation-classes
branch
from
afb0920 to
ee704dd
Compare
Owner
|
@caleridas I admire your determination, but maybe it is better to split this in multiple PRs. In particular, for the HLS transformations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate the inheritance hierarchies of SimpleOperation / StructuralOperation. This makes "SimpleOperation" the root class for all operational nodes. The inheritance hierarchy for StructuralOperation is kept for the moment, eventually the "contents" of structural operations can be entirely disassociated. They should evolve into something that can carry information specific to the structure, particularly backend-specific customizations of structural nodes.