Set rounded corners diameter automatically for Vsmart Live.#32
Open
aljjo wants to merge 1 commit intophhusson:masterfrom
Open
Set rounded corners diameter automatically for Vsmart Live.#32aljjo wants to merge 1 commit intophhusson:masterfrom
aljjo wants to merge 1 commit intophhusson:masterfrom
Conversation
Owner
|
Looks good to me.
I would just like you to run two tests:
Test A:
- Set manually the value to for instance 30
- Reboot
- Check that the actually icon offset is indeed 30 in the status bar
Test B:
- Set manually to 30
- Wait for status bar to update and display the "30" value
- Set parameter to -1
- Reboot
- Check that the actual icon offset is indeed 12 as expected
Le mar. 16 juin 2020 à 17:18, aljjo <notifications@github.com> a écrit :
… With no java or kotlin knowledge, I've searched around a lot to debug
these little lines. But it feels great to make it works.
Please tell me if this needs any modification. Thank you.
------------------------------
You can view, comment on, or merge this pull request online at:
#32
Commit Summary
- Set rounded corners diameter automatically for Vsmart Live.
File Changes
- *M* app/src/main/java/me/phh/treble/app/EntryService.kt
<https://github.com/phhusson/treble_app/pull/32/files#diff-9735a537b04f30bab1b1c26a38f23cdd>
(2)
- *M* app/src/main/java/me/phh/treble/app/OverlayPicker.kt
<https://github.com/phhusson/treble_app/pull/32/files#diff-321880753593dab05793c5cb16df7c07>
(11)
Patch Links:
- https://github.com/phhusson/treble_app/pull/32.patch
- https://github.com/phhusson/treble_app/pull/32.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#32>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAA4OS7SE3IOHTR6R5SFMDRW6ENJANCNFSM4N7XC3DQ>
.
|
(set sysui_rounded_content_padding)
aljjo
force-pushed
the
vsmartlive/roundedcorner
branch
from
4f7d3c6 to
3afb831
Compare
Author
|
I added curly brackets to fix the if statement. Now test A and B run as expected. |
danielzhang130
pushed a commit
to danielzhang130/treble_app
that referenced
this pull request
Nov 15, 2024
danielzhang130
pushed a commit
to danielzhang130/treble_app
that referenced
this pull request
Jun 2, 2025
This patch adds stylus pen support for Y700 2023. Also re-add support to d2tw, which was left out in previous pull request (phhusson#32).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With no java or kotlin knowledge, I've searched around a lot to debug these little lines. But it feels great to make it works.
Please tell me if this needs any modification. Thank you.