Return 1 byte length for zero len values when determining spaceForLength#1
Open
ou05020 wants to merge 2 commits intophilpearl:masterfrom
Open
Return 1 byte length for zero len values when determining spaceForLength#1ou05020 wants to merge 2 commits intophilpearl:masterfrom
ou05020 wants to merge 2 commits intophilpearl:masterfrom
Conversation
bits.Len returns 0 when len == 0. That results in a zero result returned by `spaceForLength` due to integer division (6/7). The writeLength function is then called using 1 byte to write the zero length value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bits.Len returns 0 when len == 0. That results in a zero result returned by
spaceForLengthdue to integer division (6/7). The writeLength function is then called using 1 byte to write the zero length value leading to a discrepancy between reserved (0) and written (1) number of bytes.This causes incorrect values to be returned for empty strings in Stringbank.Get.