Skip to content

Conversation

@chrisminett
Copy link
Member

  • Add type checks for \Stringable to quoter.
  • The PDO default quote method value param has a string type.
  • Add a placeholder for dynamic SQL statements to preserve the parentheses quote behaviour.
  • Simplify the quote type logic for the expected types.

Must be a major version as it changes the type declarations on the quoter (although there should be no impact on any standard expected usage of the package).

The PDO default quote method value param has a string type.
Add a placeholder for dynamic SQL statements to preserve the parentheses quote behaviour.
Simplify the quote type logic for the expected types.
@chrisminett chrisminett added the major-version Release MUST be major version increment label Feb 10, 2025
@chrisminett chrisminett self-assigned this Feb 10, 2025
@codecov
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.53%. Comparing base (7ed407e) to head (bcb9e78).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Adapter/QuoteHandler.php 94.73% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #16      +/-   ##
============================================
+ Coverage     97.66%   98.53%   +0.86%     
+ Complexity      128      126       -2     
============================================
  Files             9        9              
  Lines           343      341       -2     
============================================
+ Hits            335      336       +1     
+ Misses            8        5       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisminett chrisminett merged commit 5d705ad into main Feb 10, 2025
9 of 10 checks passed
@chrisminett chrisminett deleted the stringable branch February 10, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

major-version Release MUST be major version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants