Skip to content

Conversation

@Xnopyt
Copy link
Collaborator

@Xnopyt Xnopyt commented Jul 30, 2025

This fixes a deprecation warning thrown by this library when running on PHP 8.4 with E_DEPRECATED reporting enabled

Phlib\JobQueue\Exception\JobRuntimeException::__construct(): Implicitly marking parameter $previous as nullable is deprecated, the explicit nullable type must be used instead

Unit tests are still reporting a deprecation as there are some caused by the phlib/beanstalk library, these will be fixed by phlib/beanstalk#40

@chrisminett chrisminett added the patch-version Release CAN be patch version increment label Jul 31, 2025
@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.46%. Comparing base (8b6a4a9) to head (fe684bf).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #13   +/-   ##
=========================================
  Coverage     63.46%   63.46%           
  Complexity      106      106           
=========================================
  Files            10       10           
  Lines           375      375           
=========================================
  Hits            238      238           
  Misses          137      137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chrisminett chrisminett merged commit e99c87d into phlib:main Jul 31, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch-version Release CAN be patch version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants