Add batching support #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x.x #14 +/- ##
============================================
- Coverage 65.50% 65.43% -0.07%
- Complexity 103 120 +17
============================================
Files 10 10
Lines 345 434 +89
============================================
+ Hits 226 284 +58
- Misses 119 150 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amaanhassim
approved these changes
Aug 13, 2025
Xnopyt
force-pushed
the
dbscheduler-batching
branch
2 times, most recently
from
5dc0833 to
b36361a
Compare
chrisminett
reviewed
Aug 13, 2025
Xnopyt
force-pushed
the
dbscheduler-batching
branch
from
b36361a to
5484baa
Compare
chrisminett
approved these changes
Aug 13, 2025
Xnopyt
force-pushed
the
dbscheduler-batching
branch
from
5484baa to
85f37a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds batching support to the DbScheduler and SQS JobQueue, which will be used by the monitor command to improve thoughput.
There is now a batchable version of both
SchedulerInterfaceandJobQueueInterface, which are used to determine if batching is supported.DbScheduler has a configurable batch size to dermine how many records it will fetch. SQS will accept any number of jobs, but internally will split it into batches of 10 jobs per queue (which is the maximum AWS will accept at once).