Feature/#2/create enums for solver types#69
Open
olivierPigeon-RTE wants to merge 1 commit intomainfrom
Open
Conversation
olivierPigeon-RTE
force-pushed
the
feat/#2/create-enums-for-solver-types
branch
from
79adb2b to
3e2e6e1
Compare
olivierPigeon-RTE
force-pushed
the
feat/#2/create-enums-for-solver-types
branch
from
3e2e6e1 to
2b92c3e
Compare
olivierPigeon-RTE
force-pushed
the
feat/#2/create-enums-for-solver-types
branch
3 times, most recently
from
ac15b1b to
97f2aaf
Compare
Delete Solver.Names and create enums instead to make the code more robust BREAKING CHANGE: The solvers must be called with enums instead of strings from now Signed-off-by: Olivier Pigeon <olivier.pigeon@rte-france.com>
olivierPigeon-RTE
force-pushed
the
feat/#2/create-enums-for-solver-types
branch
from
97f2aaf to
1a3751f
Compare
|
SaintierFr
reviewed
Feb 17, 2026
|
|
||
| from enum import Enum | ||
|
|
||
| class SolverType(Enum): |
Member
There was a problem hiding this comment.
Can you please add a docstring to this class?
Contributor
Author
There was a problem hiding this comment.
Can you please provide a short description for each solver type anc their particularities so I can add it ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this PR already have an issue describing the problem?
Fixes #2
What kind of change does this PR introduce?
This PR replaces several string values bay enums to be more resilient and avoid typos
Does this PR introduce a breaking change or deprecate an API?