Skip to content

Rename variables to use more meaningful names#91

Open
ai-qui wants to merge 92 commits intomainfrom
feature/#22/clearer-variable-names
Open

Rename variables to use more meaningful names#91
ai-qui wants to merge 92 commits intomainfrom
feature/#22/clearer-variable-names

Conversation

@ai-qui
Copy link
Member

@ai-qui ai-qui commented Feb 11, 2026 •
edited
Loading

Please check if the PR fulfills these requirements

  • Docs have been updated and a migration guide has been added.

Does this PR already have an issue describing the problem?

cf. #22

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The migration steps are described in the migration guide

ai-qui added 30 commits February 6, 2026 11:10
@ai-qui
[WIP] Rename variables in core and power modules
06279cf 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename alt -> altitude
803245d 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename azm -> azimuth
ddf3753 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename Ta -> ambient_temperature_c
055d717 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename ws -> wind_speed_ms
fede736 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename wa -> wind_angle_deg
316b6c0 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename D -> outer_diameter_m
e0483be 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename rho -> air_density
f26e8f2 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename mu -> dynamic_viscosity
1413842 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename lambda_ -> thermal_conductivity
61f404c 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Replace R -> cable_roughness when appropriate
1919ad4 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Replace R -> roughness_ratio when appropriate
fa55175 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename lat -> latitude_deg
100ecdd 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename lon -> longitude_deg
abcd6b9 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename d -> core_diameter when appropriate
504a1ef 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename A -> outer_area_m2 when relevant
1e8fa6b 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename a -> core_area_m2 when relevant
364fb81 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename km -> magnetic_coeff
a2b5beb 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename ki -> magnetic_coeff_per_a
ee65134 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename kl -> temperature_coeff_linear
1472e70 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename kq -> temperature_coeff_quadratic
235d8c1 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename RDC20 -> dc_resistance_20c_ohm_m
6b14aad 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename T20 -> reference_temperature_c
fdeaa69 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename f -> frequency_hz when relevant
0f26b1a 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename film_temp_c -> film_temperature_c
ba6616e 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
[WIP] Add TODOs
c7e5cbc 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename reference_temp_c -> reference_temperature_c
8c3bee9 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename conductor_temp -> conductor_temperature_c
6dfca38 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename epsilon -> emissivity
6e129bc 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Rename sigma -> stefan_boltzmann_constant
a6718b1 
Signed-off-by: QUINAOU Aimee <aimee.quinaou@rte-france.com>
@ai-qui
Small renamings
4661408 
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
@ai-qui
Rename Tsg -> surface_temperature_guess_c and ...
538ca05 
	Tcg -> core_temperature_guess_c

Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
@ai-qui
Small renaming
6fbf530 
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
@ai-qui
Rename std_dev -> standard_deviation
761d8df 
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
@ai-qui
Small renaming
146bc04 
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
@ai-qui
Small renamings
86f842b 
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
@ai-qui ai-qui force-pushed the feature/#22/clearer-variable-names branch 2 times, most recently from a84a648 to b48528c Compare February 13, 2026 10:12
@ai-qui
Fix SonarQube warning
e845079 
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
@ai-qui
Small renaming
17c8e62 
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
@ai-qui
Rename dc_resistance_20c_ohm_m -> linear_resistance_dc_20c_ohm_m
943798c 
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
@ai-qui
Rename r -> radius, re -> outer_radius, ri -> core_radius
8d0b663 
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
@ai-qui
Remove TODOs
b8719cb 
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
@ai-qui ai-qui force-pushed the feature/#22/clearer-variable-names branch 2 times, most recently from 1b429e7 to b870c95 Compare February 16, 2026 08:09
@ai-qui
Rename some occurrences of T
7ba82ac 
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
@ai-qui
Rename some occurrences of Tc, temp_celsius, Tf
cf327c3 
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
@ai-qui
Rename Tk -> air_temperature_k
1b966f6 
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
@ai-qui
Rename transit -> current_a
9143c1d 
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
@ai-qui
Merge remote-tracking branch 'origin/main' into feature/#22/clearer-v…
791fc49 
…ariable-names
@ai-qui ai-qui force-pushed the feature/#22/clearer-variable-names branch from 93ee59b to 791fc49 Compare February 16, 2026 08:53
@ai-qui
[WIP] migration guide
6fb162e 
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
@ai-qui
Rename dc_resistance_20c -> linear_resistance_dc_20c_ohm_m
70801c4 
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
@ai-qui
Rename dc_resistance_low_c and dc_resistance_high_c
8f7ed6a 
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
@ai-qui
Complete migration guide
3821f84 
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
@ai-qui
Format files
056605b 
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
@ai-qui
Add copyright to migration guide
7384f7f 
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 17, 2026

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.7% Coverage on New Code
1.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ai-qui ai-qui mentioned this pull request Feb 18, 2026
Draft
1 task
@ai-qui ai-qui marked this pull request as ready for review February 18, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ai-qui ai-qui

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ai-qui

Comments