Week 3 Assignment 1 #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fullstackgl
reviewed
Jun 28, 2019
| // maintain 10000 rupees whereas Salaried account holders can maintain 0 balance. | ||
| // e. There should be a provision to update Nominee details but they cannot update account number and name. | ||
| // f. The address should contain FlatNo, Street, City, State and pin code. | ||
| import java.util.Arrays; |
Collaborator
There was a problem hiding this comment.
Every class should be in its own Java file, with a separate class for the client.
fullstackgl
reviewed
Jun 28, 2019
| abstract void getAccDetails(); | ||
| } | ||
|
|
||
| interface accountRules { |
Collaborator
There was a problem hiding this comment.
This could have just been an abstract function inside the base class.
fullstackgl
reviewed
Jun 28, 2019
| } | ||
|
|
||
| @Override | ||
| public void withdrawFunc(double amount) { |
Collaborator
There was a problem hiding this comment.
Maybe add a fail message if the conditions are not met. Ditto for all the other conditions in the program.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java Code for Week 3 Assignment 1