Fixed HUD aspect ratio on mobile devices#5
Open
nicklockwood wants to merge 1 commit intophoboslab:masterfrom
Open
Fixed HUD aspect ratio on mobile devices#5nicklockwood wants to merge 1 commit intophoboslab:masterfrom
nicklockwood wants to merge 1 commit intophoboslab:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HUD size was hard-coded to 640x480, which causes it to look stretched on iPhone (especially noticeable with the grenade launcher), which has a different aspect ratio (see screenshot):
I originally tried just using the canvas width/height instead of a hard-coded value, which fixes the problem on iPhone, but causes the grenade launcher to look too small on an iPad relative to the size of the grenades:
So instead, I've kept 640 for the width, but set the height proportional to the canvas size. This means that the HUD always maintains the same scale relative to the screen width (and the grenades that it fires), but doesn't get distorted for screens with different aspect ratios: