Fix misalignment of grenade projectile sprite after recycling#6
Open
nicklockwood wants to merge 1 commit intophoboslab:masterfrom
Open
Fix misalignment of grenade projectile sprite after recycling#6nicklockwood wants to merge 1 commit intophoboslab:masterfrom
nicklockwood wants to merge 1 commit intophoboslab:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a grenade entity was recycled from the EntityPool, the offset compensation for the sprite size wasn't being applied, with the result that the sprite was offset to the right with respect the barrel of the grenade launcher.
This fix applies the same offset when resetting a recycled grenade as is applied when it's first created.
Note: It would be more robust if there was a way to share the setup code between the init and reset functions, since they are mostly identical, but I'm not sure how best to do that given the need to call this.parent().