Skip to content

Minor Fixes Found By Dialyzer #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 5 commits into from
Jan 27, 2025
Merged

Minor Fixes Found By Dialyzer #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7d5540d
Set the timeout to max between itself and the boot_timeout
probably-not Jan 7, 2025
59fe023
Fix the File.stream! call variable order
probably-not Jan 7, 2025
2e9e895
Remove impossible match
probably-not Jan 7, 2025
3ec1260
Revert "Set the timeout to max between itself and the boot_timeout"
probably-not Jan 27, 2025
08e9788
Update lib/flame/code_sync.ex
josevalim Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/flame/code_sync.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@ defmodule FLAME.CodeSync do
log_verbose("packaged size: #{File.stat!(out_path).size / (1024 * 1024)}mb")
end

# TODO: Change to File.stream!(out_path, code.chunk_size) once we require Elixir v1.16+
File.stream!(out_path, [], code.chunk_size)
end

Expand Down
3 changes: 0 additions & 3 deletions lib/flame/pool.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,9 +306,6 @@ defmodule FLAME.Pool do
if Keyword.fetch!(place_opts, :link), do: Process.link(child_pid)
{:cancel, {:replace, [child_pid]}, result}

:ignore ->
{:cancel, :ok, :ignore}

{:error, _reason} = result ->
{:cancel, :ok, result}
end
Expand Down
Loading