-
Notifications
You must be signed in to change notification settings - Fork 837
Add NoDiscard attribute #5041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add NoDiscard attribute #5041
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,160 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <reference xml:id="class.nodiscard" role="class" xmlns="http://docbook.org/ns/docbook" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:xi="http://www.w3.org/2001/XInclude"> | ||
| <title>The NoDiscard attribute</title> | ||
| <titleabbrev>NoDiscard</titleabbrev> | ||
|
|
||
| <partintro> | ||
|
|
||
| <section xml:id="nodiscard.intro"> | ||
| &reftitle.intro; | ||
| <simpara> | ||
| This attribute can be used to indicate that the return value of a function | ||
| or a method should not be discarded. If the return value is not used in any | ||
| way, a warning will be emitted. | ||
| </simpara> | ||
| <simpara> | ||
| This is useful for functions where not checking the return value is likely | ||
| to be a bug. | ||
| </simpara> | ||
| <simpara> | ||
| To intentionally discard the return value of such a function, use (void) | ||
| cast to suppress the warning. | ||
| </simpara> | ||
| </section> | ||
|
|
||
| <section xml:id="nodiscard.synopsis"> | ||
| &reftitle.classsynopsis; | ||
|
|
||
| <classsynopsis class="class"> | ||
| <ooclass> | ||
| <modifier>final</modifier> | ||
| <classname>NoDiscard</classname> | ||
| </ooclass> | ||
|
|
||
| <classsynopsisinfo role="comment">&Properties;</classsynopsisinfo> | ||
| <fieldsynopsis> | ||
| <modifier>public</modifier> | ||
| <modifier>readonly</modifier> | ||
| <type class="union"><type>string</type><type>null</type></type> | ||
| <varname linkend="nodiscard.props.message">message</varname> | ||
| </fieldsynopsis> | ||
|
|
||
| <classsynopsisinfo role="comment">&Methods;</classsynopsisinfo> | ||
| <xi:include xpointer="xmlns(db=http://docbook.org/ns/docbook) xpointer(id('class.nodiscard')/db:refentry/db:refsect1[@role='description']/descendant::db:constructorsynopsis[@role='NoDiscard'])"> | ||
| <xi:fallback/> | ||
| </xi:include> | ||
| </classsynopsis> | ||
|
|
||
| </section> | ||
|
|
||
| <section xml:id="nodiscard.props"> | ||
| &reftitle.properties; | ||
| <variablelist> | ||
| <varlistentry xml:id="nodiscard.props.message"> | ||
| <term><varname>message</varname></term> | ||
| <listitem> | ||
| <para> | ||
| An optional message explaining why the return value should not be discarded. | ||
| </para> | ||
| </listitem> | ||
| </varlistentry> | ||
| </variablelist> | ||
| </section> | ||
|
|
||
| <section> | ||
| &reftitle.examples; | ||
| <example> | ||
| <title>Basic usage</title> | ||
| <programlisting role="php"> | ||
| <![CDATA[ | ||
| <?php | ||
|
|
||
| /** | ||
| * Processes all the given items and returns an array with the results of the | ||
| * operation for each item. `null` indicates success and an Exception indicates | ||
| * an error. The keys of the result array match the keys of the $items array. | ||
| * | ||
| * @param array<string> $items | ||
| * @return array<null|Exception> | ||
| */ | ||
| #[\NoDiscard("as processing might fail for individual items")] | ||
| function bulk_process(array $items): array { | ||
| $results = []; | ||
|
|
||
| foreach ($items as $key => $item) { | ||
| if (\random_int(0, 9999) < 9999) { | ||
| // Pretend to do something useful with $item, | ||
| // which will succeed in 99.99% of cases. | ||
| echo "Processing {$item}", PHP_EOL; | ||
| $error = null; | ||
| } else { | ||
| $error = new \Exception("Failed to process {$item}."); | ||
| } | ||
|
|
||
| $results[$key] = $error; | ||
| } | ||
|
|
||
| return $results; | ||
| } | ||
|
|
||
| ?> | ||
| ]]> | ||
| </programlisting> | ||
| &example.outputs.85.similar; | ||
| <screen> | ||
| <![CDATA[ | ||
| Warning: The return value of function bulk_process() should either be used or intentionally ignored by casting it as (void), as processing might fail for individual items | ||
| ]]> | ||
| </screen> | ||
| </example> | ||
| <example> | ||
| <title>Intentionally discarding the return value</title> | ||
| <programlisting role="php"> | ||
| <![CDATA[ | ||
| <?php | ||
|
|
||
| #[\NoDiscard] | ||
| function some_command(): int { | ||
| return 1; | ||
| } | ||
|
|
||
| (void) some_command(); | ||
|
|
||
| ?> | ||
| ]]> | ||
| </programlisting> | ||
| </example> | ||
| </section> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I suggest also documented somewhere (maybe just an example) for a
|
||
|
|
||
| <section xml:id="nodiscard.seealso"> | ||
| &reftitle.seealso; | ||
| <simplelist> | ||
| <member><link linkend="language.attributes">Attributes overview</link></member> | ||
| </simplelist> | ||
| </section> | ||
|
|
||
| </partintro> | ||
|
|
||
| &language.predefined.attributes.nodiscard.construct; | ||
|
|
||
| </reference> | ||
| <!-- Keep this comment at the end of the file | ||
| Local variables: | ||
| mode: sgml | ||
| sgml-omittag:t | ||
| sgml-shorttag:t | ||
| sgml-minimize-attributes:nil | ||
| sgml-always-quote-attributes:t | ||
| sgml-indent-step:1 | ||
| sgml-indent-data:t | ||
| indent-tabs-mode:nil | ||
| sgml-parent-document:nil | ||
| sgml-default-dtd-file:"~/.phpdoc/manual.ced" | ||
| sgml-exposed-tags:nil | ||
| sgml-local-catalogs:nil | ||
| sgml-local-ecat-files:nil | ||
| End: | ||
| vim600: syn=xml fen fdm=syntax fdl=2 si | ||
| vim: et tw=78 syn=sgml | ||
| vi: ts=1 sw=1 | ||
| --> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- $Revision$ --> | ||
| <refentry xml:id="nodiscard.construct" xmlns="http://docbook.org/ns/docbook" xmlns:xlink="http://www.w3.org/1999/xlink"> | ||
| <refnamediv> | ||
| <refname>NoDiscard::__construct</refname> | ||
| <refpurpose>Construct a new NoDiscard attribute instance</refpurpose> | ||
| </refnamediv> | ||
|
|
||
| <refsect1 role="description"> | ||
| &reftitle.description; | ||
| <constructorsynopsis role="NoDiscard"> | ||
| <modifier>public</modifier> <methodname>NoDiscard::__construct</methodname> | ||
| <methodparam choice="opt"><type class="union"><type>string</type><type>null</type></type><parameter>message</parameter><initializer>&null;</initializer></methodparam> | ||
| </constructorsynopsis> | ||
| <simpara> | ||
| Constructs a new <classname>NoDiscard</classname> instance. | ||
| </simpara> | ||
| </refsect1> | ||
|
|
||
| <refsect1 role="parameters"> | ||
| &reftitle.parameters; | ||
| <variablelist> | ||
| <varlistentry> | ||
| <term><parameter>message</parameter></term> | ||
| <listitem> | ||
| <para> | ||
| The value of the <property linkend="nodiscard.props.message">message</property> property. | ||
| </para> | ||
| </listitem> | ||
| </varlistentry> | ||
| </variablelist> | ||
| </refsect1> | ||
| </refentry> | ||
| <!-- Keep this comment at the end of the file | ||
| Local variables: | ||
| mode: sgml | ||
| sgml-omittag:t | ||
| sgml-shorttag:t | ||
| sgml-minimize-attributes:nil | ||
| sgml-always-quote-attributes:t | ||
| sgml-indent-step:1 | ||
| sgml-indent-data:t | ||
| indent-tabs-mode:nil | ||
| sgml-parent-document:nil | ||
| sgml-default-dtd-file:"~/.phpdoc/manual.ced" | ||
| sgml-exposed-tags:nil | ||
| sgml-local-catalogs:nil | ||
| sgml-local-ecat-files:nil | ||
| End: | ||
| vim600: syn=xml fen fdm=syntax fdl=2 si | ||
| vim: et tw=78 syn=sgml | ||
| vi: ts=1 sw=1 | ||
| --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
presumably you also have to call the function somewhere