Document Locale::isRightToLeft (PHP 8.5) #5055
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielEScherzer
requested changes
Dec 27, 2025
Member
DanielEScherzer
left a comment
DanielEScherzer
left a comment
There was a problem hiding this comment.
Methods are generally documented in their own dedicated files, that are then linked in the synopsis below (see the line <classsynopsisinfo role="comment">&Methods;</classsynopsisinfo> and below it)
Its been a decade, but the last new Locale method documented seems to have been 53e4cea and you can see how that was documented - just create a new file
Looking through the commit log, it seems the most recent method addition documentation was 053ae3f so that can also be used for comparison - in addition to creating the new file, the versions information gets updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for
Locale::isRightToLeft(), which was introduced in PHP 8.5 but was not previously documented in the manual.The new section describes the method behavior, its reliance on ICU for determining text direction, and provides a simple usage example.
Fixes #5013