Fix outdated documentation for ReflectionClass::setStaticPropertyValue visibility handling #5057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacatoire
force-pushed
the
reflection/setstaticpropertyvalue-doc
branch
from
0a87feb to
a6b09b8
Compare
DanielEScherzer
requested changes
Dec 26, 2025
| <methodname>ReflectionProperty::setValue</methodname> allows setting | ||
| the value of public, private, and protected properties. | ||
| <methodname>ReflectionProperty::setValue</methodname> can also be | ||
| used to set the value of static properties.allows setting. |
Member
There was a problem hiding this comment.
Suggested change
| used to set the value of static properties.allows setting. | |
| used to set the value of static properties. |
looks like this was left over
| </entry> | ||
| </row> | ||
| <row> | ||
| <entry>7.4.9</entry> |
Member
There was a problem hiding this comment.
there should also be documentation of which minor (non-patch) version of PHP this was first changed in, e.g. it could be that 7.4.9 was released after 8.0.0 and thus PHP 8.0 only allows public static properties, or that 7.4.9 was before 8.0.0 and the change was also in 8.0.0, but without further detail a reader would need to investigate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 4600 The documentation for
ReflectionClass::setStaticPropertyValue()is outdated.Since PHP 7.4.9, this method can set static properties regardless of their visibility (public, protected, or private), which is covered by core tests. The current description still states that private and protected properties would fail.
This PR updates: