Conversation
Make use of astropy to do the conversion so also need to add it as a dependency to the project.
There was some cleaning of the units to allow astropy to do the conversion and some setting of types to ensure it wouldn't fail.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
+ Coverage 98.87% 98.90% +0.02%
==========================================
Files 10 10
Lines 710 729 +19
==========================================
+ Hits 702 721 +19
Misses 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is a bit of a cop-out, but tests are failing against this version but not later ones and I don't want to spend time pushing changes and using runners as my debug tool. 3.10 stopped receiving active support over 2.5 years ago and will go EOL in 10 months so I'm comfortable removing support. There are 4 newer versions people can use.
Owner
Author
|
Have dropped support for python 3.10 as the tests were failing for that version, but not the newer versions. Not sure what the issue is and don't want to keep pushing and using runners as my debug tool. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start working on #5
We leverage astropy to convert the time unit into seconds so need to update some existing units, e.g. astropy expects "yr" not "y" and "min" not "m".