refactor: support emojis and high unicode characters #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Change fontDefType.Cw and utf8FontFile.CharWidths from slice to map[int]int to support sparse and high unicode characters (fixing crash). - Update utf8toutf16 to correctly handle 4-byte UTF-8 sequences using surrogate pairs. - Add UnmarshalJSON to fontDefType to backward-compatibility with array-based font definitions. - Remove hardcoded limit checks for character widths.
Changes: - Implement CMAP Format 12 parsing in utf8fontfile.go. - Implement CID remapping in fpdf.go to support characters outside BMP (e.g. Emojis). - Add runeToCid map to fontDefType. - Add helper methods stringToCIDs and getOrAssignCID. - Update Text, CellFormat, and generateCIDFontMap to use CID remapping and correct width lookup. - Update parseSymbols to use CIDs as keys for GID lookup.
avdoseferovic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR implements full support for emojis and Unicode characters outside the BMP.
It includes:
emoji.pdf