Query type inference failures reproductions

[ondrejmirtes]

No description provided.

[ondrejmirtes]

Alright @VincentLanglet, here's one:

--- Expected
+++ Actual
@@ @@
-'list<array{id: int}>'
+'list<array{id: int|numeric-string|null}>'

[VincentLanglet]

Alright @VincentLanglet, here's one:

--- Expected
+++ Actual
@@ @@
-'list<array{id: int}>'
+'list<array{id: int|numeric-string|null}>'

If I dump the Query, I get

Doctrine\ORM\Query<null, array{id: int|numeric-string|null}>

so QueryResultDynamicReturnTypeExtension works fine but the issue seems to be with QueryResultTypeWalker

This is a consequence of #273 (cc @arnaud-lb)
and there is the following test case.

'identity function' => [
				$this->constantArray([
					[new ConstantIntegerType(1), TypeCombinator::addNull($this->numericStringOrInt())],
					[new ConstantIntegerType(2), $this->numericStringOrInt()],
					[new ConstantIntegerType(3), TypeCombinator::addNull($this->numericStringOrInt())],
					[new ConstantIntegerType(4), TypeCombinator::addNull(new StringType())],
					[new ConstantIntegerType(5), TypeCombinator::addNull(new StringType())],
					[new ConstantIntegerType(6), TypeCombinator::addNull($this->numericStringOrInt())],
					[new ConstantIntegerType(7), TypeCombinator::addNull(new MixedType())],
					[new ConstantIntegerType(8), TypeCombinator::addNull($this->numericStringOrInt())],
				]),
				'
					SELECT		IDENTITY(m.oneNull),
								IDENTITY(m.one),
								IDENTITY(m.oneDefaultNullability),
								IDENTITY(m.compoundPk),
								IDENTITY(m.compoundPk, \'id\'),
								IDENTITY(m.compoundPk, \'version\'),
								IDENTITY(m.compoundPkAssoc),
								IDENTITY(m.compoundPkAssoc, \'version\')
					FROM		QueryResult\Entities\Many m
				',
			],

I'll need to investigate why numericStringOrInt is used

[VincentLanglet]

I identified that the numeric-string is because of the following code

phpstan-doctrine/src/Type/Doctrine/Query/QueryResultTypeWalker.php

Lines 837 to 855 in a1ba454

	} else {
	// Expressions default to Doctrine's StringType, whose
	// convertToPHPValue() is a no-op. So the actual type depends on
	// the driver and PHP version.
	// Here we assume that the value may or may not be casted to
	// string by the driver.
	$type = TypeTraverser::map($type, static function (Type $type, callable $traverse): Type {
	if ($type instanceof UnionType || $type instanceof IntersectionType) {
	return $traverse($type);
	}
	if ($type instanceof IntegerType || $type instanceof FloatType) {
	return TypeCombinator::union($type->toString(), $type);
	}
	if ($type instanceof BooleanType) {
	return TypeCombinator::union($type->toInteger()->toString(), $type);
	}
	return $traverse($type);
	});
	}

[VincentLanglet]

I try finding some "solutions" for this issue.

But I discovered a new one.

$result = $this->entityManager->createQueryBuilder()
			->select('p.id AS id')
			->from(OrderItem::class, 'oi')
			->join('oi.product', 'p')
			->getQuery()
			->getArrayResult();
		assertType('list<array{id: int}>', $result);

Works

$result = $this->entityManager->createQueryBuilder()
			->select('p.id AS id')
			->from(OrderItem::class, 'oi')
			->leftJoin('oi.product', 'p')
			->getQuery()
			->getArrayResult();
		assertType('list<array{id: int|null}>', $result);

Also works But

$result = $this->entityManager->createQueryBuilder()
			->select('p.id AS id')
			->from(OrderItem::class, 'oi')
			->leftJoin('oi.product', 'p')
			->where('p.id IS NOT NULL')
			->getQuery()
			->getArrayResult();
		assertType('list<array{id: int}>', $result);

doesn't.

The where condition are not supported, and this may be too complicated to support them.

So far, I think I'll have to change every Union to BenevolentUnion then...

[VincentLanglet]

I will need your opinion on this solution @ondrejmirtes #447

[ondrejmirtes]

Continued in #593