OtherMethodQueryBuilderParser: prevent broken type infering with partial analysis#504
Open
janedbal wants to merge 2 commits intophpstan:1.3.xfrom
Open
Conversation
ondrejmirtes
requested changes
Jan 5, 2024
ondrejmirtes
requested changes
Jan 17, 2024
Member
ondrejmirtes
left a comment
ondrejmirtes
left a comment
There was a problem hiding this comment.
I've looked into this and thought about it. The problem is that a lot of files will now be cached twice in memory because here you're using a new instance of the cached parser.
Ideally you'd reuse the existing cache for already parsed files by the rich parser and just cache differently parsed files that are otherwise parsed by the simple parser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when a file is not among "analysed files" (which is any file not listed in partial analysis), every method body is stripped by CleaningParser. Due to that OtherMethodQueryBuilderParser cannot determine what is happening to the QueryBuilder there and results in
mixed. This results in nasty:mixedreturnedlist<Entity>returnedDue to the nature of this feature (affecting only methods returning QueryBuilder) I think it is safe to remove the CleaningParser even with this improvement.