Check field names of orderBy parameter in findBy and findOneBy#683
Open
whataboutpereira wants to merge 1 commit intophpstan:2.0.xfrom
Open
Check field names of orderBy parameter in findBy and findOneBy#683whataboutpereira wants to merge 1 commit intophpstan:2.0.xfrom
whataboutpereira wants to merge 1 commit intophpstan:2.0.xfrom
Conversation
e27b1ee to
5df2683
Compare
Contributor
|
@ondrejmirtes could you rebase this branch so we can see how/whether mutation testing is doing here? |
5df2683 to
fb46445
Compare
Member
|
Rebased |
Contributor
|
thanks. test succeeded, as this PR does not contain any |
fb46445 to
d8134cc
Compare
…indOneBy repository methods.
d8134cc to
d3a1d2a
Compare
ondrejmirtes
requested changes
Feb 5, 2026
Member
ondrejmirtes
left a comment
There was a problem hiding this comment.
Sorry for this late review. Given this adds a new error, this should only be happening with Bleeding Edge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check valid field names are used in orderBy parameter of findBy and findOneBy repository methods (issue #674).
Unfortunately this won't catch a nested call like this: