Declare Connection::fetch methods as impure#708
Open
VincentLanglet wants to merge 1 commit intophpstan:2.0.xfrom
Open
Declare Connection::fetch methods as impure#708VincentLanglet wants to merge 1 commit intophpstan:2.0.xfrom
VincentLanglet wants to merge 1 commit intophpstan:2.0.xfrom
Conversation
VincentLanglet
force-pushed
the
fetchImpure
branch
from
4576c7b to
f66c965
Compare
VincentLanglet
force-pushed
the
fetchImpure
branch
from
f66c965 to
71b1cb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #685
This would avoid issue like this one phpstan/phpstan-phpunit#232 (comment)
(cc @greg0ire)
Another solution could be to merge phpstan/phpstan-src#4422 and use the new tag on the whole class.