Skip to content

Test chaining with static/self and $this more #3363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mvorisek wants to merge 1 commit into
base: 2.1.x
Choose a base branch
from
Draft

Test chaining with static/self and $this more #3363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 108 additions & 0 deletions tests/PHPStan/Analyser/nsrt/static-with-this-chained-bug-5946.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,108 @@
<?php

namespace StaticWithThisChained;

use function PHPStan\Testing\assertType;

class Foo
{
/** @var $this */
public $propThis;

/** @var static */
public $propStatic;

/** @var static */
public static $propStaticStatic;

/**
* @return $this
*/
public function getThis()
{
return $this;
}

/**
* @return static
*/
public function newStatic()
{
return new static();
}

/**
* @return static
*/
public static function newStaticStatic()
{
return new static();
}

public function testMethodChained(): void
{
assertType('$this(StaticWithThisChained\Foo)', $this->getThis());
assertType('static(StaticWithThisChained\Foo)', $this->newStatic());
assertType('static(StaticWithThisChained\Foo)', static::newStaticStatic());
assertType('static(StaticWithThisChained\Foo)', self::newStaticStatic());
assertType('StaticWithThisChained\Foo', Foo::newStaticStatic());

assertType('$this(StaticWithThisChained\Foo)', $this->getThis()->getThis());
assertType('static(StaticWithThisChained\Foo)', $this->newStatic()->getThis());
assertType('static(StaticWithThisChained\Foo)', static::newStaticStatic()->getThis());
assertType('static(StaticWithThisChained\Foo)', self::newStaticStatic()->getThis());
assertType('StaticWithThisChained\Foo', Foo::newStaticStatic()->getThis());
}

public function testPropertyChained(): void
{
assertType('$this(StaticWithThisChained\Foo)', $this->propThis);
assertType('static(StaticWithThisChained\Foo)', $this->propStatic);
assertType('static(StaticWithThisChained\Foo)', static::$propStaticStatic);
assertType('static(StaticWithThisChained\Foo)', self::$propStaticStatic);
assertType('static(StaticWithThisChained\Foo)', Foo::$propStaticStatic); // should be StaticWithThisChained\Foo

assertType('$this(StaticWithThisChained\Foo)', $this->propThis->propThis);
assertType('static(StaticWithThisChained\Foo)', $this->propStatic->propThis);
assertType('static(StaticWithThisChained\Foo)', static::$propStaticStatic->propThis);
assertType('static(StaticWithThisChained\Foo)', self::$propStaticStatic->propThis);
assertType('static(StaticWithThisChained\Foo)', Foo::$propStaticStatic->propThis); // should be StaticWithThisChained\Foo
}
}

class Bar extends Foo
{
public function testMethodChained(): void
{
assertType('$this(StaticWithThisChained\Bar)', $this->getThis());
assertType('static(StaticWithThisChained\Bar)', $this->newStatic());
assertType('static(StaticWithThisChained\Bar)', static::newStaticStatic());
assertType('static(StaticWithThisChained\Bar)', self::newStaticStatic());
assertType('StaticWithThisChained\Foo', Foo::newStaticStatic());
assertType('StaticWithThisChained\Bar', Bar::newStaticStatic());

assertType('$this(StaticWithThisChained\Bar)', $this->getThis()->getThis());
assertType('static(StaticWithThisChained\Bar)', $this->newStatic()->getThis());
assertType('static(StaticWithThisChained\Bar)', static::newStaticStatic()->getThis());
assertType('static(StaticWithThisChained\Bar)', self::newStaticStatic()->getThis());
assertType('StaticWithThisChained\Foo', Foo::newStaticStatic()->getThis());
assertType('StaticWithThisChained\Bar', Bar::newStaticStatic()->getThis());
}

public function testPropertyChained(): void
{
assertType('$this(StaticWithThisChained\Bar)', $this->propThis);
assertType('static(StaticWithThisChained\Bar)', $this->propStatic);
assertType('static(StaticWithThisChained\Bar)', static::$propStaticStatic);
assertType('static(StaticWithThisChained\Bar)', self::$propStaticStatic);
assertType('static(StaticWithThisChained\Bar)', Foo::$propStaticStatic); // should be StaticWithThisChained\Foo (non-static and Foo, not Bar)
assertType('static(StaticWithThisChained\Bar)', Bar::$propStaticStatic); // should be StaticWithThisChained\Bar (non-static)

assertType('$this(StaticWithThisChained\Bar)', $this->propThis->propThis);
assertType('static(StaticWithThisChained\Bar)', $this->propStatic->propThis);
assertType('static(StaticWithThisChained\Bar)', static::$propStaticStatic->propThis);
assertType('static(StaticWithThisChained\Bar)', self::$propStaticStatic->propThis);
assertType('static(StaticWithThisChained\Bar)', Foo::$propStaticStatic->propThis); // should be StaticWithThisChained\Foo (non-static and Foo, not Bar)
assertType('static(StaticWithThisChained\Bar)', Bar::$propStaticStatic->propThis); // should be StaticWithThisChained\Bar (non-static)
}
}
Loading