Fix version_compare return type #4178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
versionCompare
branch
from
979ca3f to
b094f4e
Compare
Collaborator
|
This pull request has been marked as ready for review. |
Member
|
Thank you. |
| continue; | ||
| } | ||
|
|
||
| $value = version_compare($version1String->getValue(), $version2String->getValue(), $operatorValue); |
Member
There was a problem hiding this comment.
Hey, here's bool and then it's used in $types[$value] which gets picked up with reportNonIntStringArrayKey: true. Can you please fix it? I' ignoring this issue in 2.1.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#4457
Also avoid the following error
https://phpstan.org/r/e5138f79-6672-4a17-9cd2-531791bc016d