Support StaticMethodParameterClosureTypeExtension for New_ expressions#4819
Merged
ondrejmirtes merged 1 commit intophpstan:2.1.xfrom Jan 25, 2026
Conversation
Contributor
Author
|
It seems these failures are not related to this PR but coming from the main branch. |
Member
|
Thank you! |
samsonasik
reviewed
Jan 26, 2026
| $staticCall = new StaticCall( | ||
| $callLike->class, | ||
| new Identifier('__construct'), | ||
| $callLike->getArgs(), |
Contributor
There was a problem hiding this comment.
We use NodeScopeResolver in rector, I think getArgs() should be replaced with args here, or check isFirstClassCallable() early here to avoid error assert error, see:
Member
There was a problem hiding this comment.
$callLike here cannot be a first class callable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See phpstan/phpstan#14014 (comment)
Decided to add support to the current extensions to make it easier to merge this instead of proposing the change to:
/cc @ondrejmirtes @calebdw