Skip to content

Don't invalidate container cache on user-interactions in the shell #4924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 1 commit into from
Feb 14, 2026
Merged

Don't invalidate container cache on user-interactions in the shell #4924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions src/DependencyInjection/Configurator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,20 +87,28 @@ public function loadContainer(): string
$staticParameters = $this->staticParameters;
ksort($staticParameters['env']);
unset($staticParameters['env']['_']);
// make sure variables which can get defined by the shell
// after user-interactions with the UI will not invalidate the container cache
unset($staticParameters['env']['SHLVL']);
unset($staticParameters['env']['OLDPWD']);
unset($staticParameters['env']['LINES']);
unset($staticParameters['env']['COLUMNS']);
unset($staticParameters['env']['SHELL_VERBOSITY']);

$containerKey = [
$staticParameters,
array_keys($this->dynamicParameters),
$this->configs,
PHP_VERSION_ID - PHP_RELEASE_VERSION,
is_file($attributesPhp) ? hash_file('sha256', $attributesPhp) : 'attributes-missing',
NeonAdapter::CACHE_KEY,
$this->getAllConfigFilesHashes(),
var_export(TurboExtensionEnabler::isLoaded(), true),
];

$className = $loader->load(
[$this, 'generateContainer'],
[
$staticParameters,
array_keys($this->dynamicParameters),
$this->configs,
PHP_VERSION_ID - PHP_RELEASE_VERSION,
is_file($attributesPhp) ? hash_file('sha256', $attributesPhp) : 'attributes-missing',
NeonAdapter::CACHE_KEY,
$this->getAllConfigFilesHashes(),
var_export(TurboExtensionEnabler::isLoaded(), true),
],
$containerKey,
);

if ($this->journalContainer) {
Expand Down
Loading