Skip to content

ClassNameCheck: Retrieve extensions just once #4926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
staabm wants to merge 4 commits into
base: 2.1.x
Choose a base branch
from
+44 −22
Open

ClassNameCheck: Retrieve extensions just once #4926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
544e566
ClassNameCheck: Retrieve extensions just once
staabm Feb 14, 2026
8697e20
cs
staabm Feb 14, 2026
9b72e37
lazy property
staabm Feb 14, 2026
6ab60b5
same fix Restricted*Rule
staabm Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Rules/ClassNameCheck.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
final class ClassNameCheck
{

/** @var RestrictedClassNameUsageExtension[] $extensions */
private ?array $extensions = null;

public function __construct(
private ClassCaseSensitivityCheck $classCaseSensitivityCheck,
private ClassForbiddenNameCheck $classForbiddenNameCheck,
Expand Down Expand Up @@ -47,8 +50,7 @@ public function checkClassNames(
return $errors;
}

/** @var RestrictedClassNameUsageExtension[] $extensions */
$extensions = $this->container->getServicesByTag(RestrictedClassNameUsageExtension::CLASS_NAME_EXTENSION_TAG);
$extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedClassNameUsageExtension::CLASS_NAME_EXTENSION_TAG);
if ($extensions === []) {
return $errors;
}
Expand Down
6 changes: 4 additions & 2 deletions src/Rules/RestrictedUsage/RestrictedClassConstantUsageRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@
final class RestrictedClassConstantUsageRule implements Rule
{

/** @var RestrictedClassConstantUsageExtension[] $extensions */
private ?array $extensions = null;

public function __construct(
private Container $container,
private ReflectionProvider $reflectionProvider,
Expand All @@ -44,8 +47,7 @@ public function processNode(Node $node, Scope $scope): array
return [];
}

/** @var RestrictedClassConstantUsageExtension[] $extensions */
$extensions = $this->container->getServicesByTag(RestrictedClassConstantUsageExtension::CLASS_CONSTANT_EXTENSION_TAG);
$extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedClassConstantUsageExtension::CLASS_CONSTANT_EXTENSION_TAG);
if ($extensions === []) {
return [];
}
Expand Down
6 changes: 4 additions & 2 deletions src/Rules/RestrictedUsage/RestrictedFunctionCallableUsageRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@
final class RestrictedFunctionCallableUsageRule implements Rule
{

/** @var RestrictedFunctionUsageExtension[] $extensions */
private ?array $extensions = null;

public function __construct(
private Container $container,
private ReflectionProvider $reflectionProvider,
Expand Down Expand Up @@ -46,8 +49,7 @@ public function processNode(Node $node, Scope $scope): array

$functionReflection = $this->reflectionProvider->getFunction($node->getName(), $scope);

/** @var RestrictedFunctionUsageExtension[] $extensions */
$extensions = $this->container->getServicesByTag(RestrictedFunctionUsageExtension::FUNCTION_EXTENSION_TAG);
$extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedFunctionUsageExtension::FUNCTION_EXTENSION_TAG);
$errors = [];

foreach ($extensions as $extension) {
Expand Down
6 changes: 4 additions & 2 deletions src/Rules/RestrictedUsage/RestrictedFunctionUsageRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
final class RestrictedFunctionUsageRule implements Rule
{

/** @var RestrictedFunctionUsageExtension[] $extensions */
private ?array $extensions = null;

public function __construct(
private Container $container,
private ReflectionProvider $reflectionProvider,
Expand Down Expand Up @@ -45,8 +48,7 @@ public function processNode(Node $node, Scope $scope): array

$functionReflection = $this->reflectionProvider->getFunction($node->name, $scope);

/** @var RestrictedFunctionUsageExtension[] $extensions */
$extensions = $this->container->getServicesByTag(RestrictedFunctionUsageExtension::FUNCTION_EXTENSION_TAG);
$extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedFunctionUsageExtension::FUNCTION_EXTENSION_TAG);
$errors = [];

foreach ($extensions as $extension) {
Expand Down
6 changes: 4 additions & 2 deletions src/Rules/RestrictedUsage/RestrictedMethodCallableUsageRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@
final class RestrictedMethodCallableUsageRule implements Rule
{

/** @var RestrictedMethodUsageExtension[] $extensions */
private ?array $extensions = null;

public function __construct(
private Container $container,
private ReflectionProvider $reflectionProvider,
Expand All @@ -40,8 +43,7 @@ public function processNode(Node $node, Scope $scope): array
return [];
}

/** @var RestrictedMethodUsageExtension[] $extensions */
$extensions = $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);
$extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);
if ($extensions === []) {
return [];
}
Expand Down
6 changes: 4 additions & 2 deletions src/Rules/RestrictedUsage/RestrictedMethodUsageRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@
final class RestrictedMethodUsageRule implements Rule
{

/** @var RestrictedMethodUsageExtension[] $extensions */
private ?array $extensions = null;

public function __construct(
private Container $container,
private ReflectionProvider $reflectionProvider,
Expand All @@ -40,8 +43,7 @@ public function processNode(Node $node, Scope $scope): array
return [];
}

/** @var RestrictedMethodUsageExtension[] $extensions */
$extensions = $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);
$extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);
if ($extensions === []) {
return [];
}
Expand Down
6 changes: 4 additions & 2 deletions src/Rules/RestrictedUsage/RestrictedPropertyUsageRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
final class RestrictedPropertyUsageRule implements Rule
{

/** @var RestrictedPropertyUsageExtension[] $extensions */
private ?array $extensions = null;

public function __construct(
private Container $container,
private ReflectionProvider $reflectionProvider,
Expand All @@ -39,8 +42,7 @@ public function processNode(Node $node, Scope $scope): array
return [];
}

/** @var RestrictedPropertyUsageExtension[] $extensions */
$extensions = $this->container->getServicesByTag(RestrictedPropertyUsageExtension::PROPERTY_EXTENSION_TAG);
$extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedPropertyUsageExtension::PROPERTY_EXTENSION_TAG);
if ($extensions === []) {
return [];
}
Expand Down
6 changes: 4 additions & 2 deletions src/Rules/RestrictedUsage/RestrictedStaticMethodCallableUsageRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
final class RestrictedStaticMethodCallableUsageRule implements Rule
{

/** @var RestrictedMethodUsageExtension[] $extensions */
private ?array $extensions = null;

public function __construct(
private Container $container,
private ReflectionProvider $reflectionProvider,
Expand All @@ -45,8 +48,7 @@ public function processNode(Node $node, Scope $scope): array
return [];
}

/** @var RestrictedMethodUsageExtension[] $extensions */
$extensions = $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);
$extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);
if ($extensions === []) {
return [];
}
Expand Down
6 changes: 4 additions & 2 deletions src/Rules/RestrictedUsage/RestrictedStaticMethodUsageRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@
final class RestrictedStaticMethodUsageRule implements Rule
{

/** @var RestrictedMethodUsageExtension[] $extensions */
private ?array $extensions = null;

public function __construct(
private Container $container,
private ReflectionProvider $reflectionProvider,
Expand All @@ -44,8 +47,7 @@ public function processNode(Node $node, Scope $scope): array
return [];
}

/** @var RestrictedMethodUsageExtension[] $extensions */
$extensions = $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);
$extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);
if ($extensions === []) {
return [];
}
Expand Down
6 changes: 4 additions & 2 deletions src/Rules/RestrictedUsage/RestrictedStaticPropertyUsageRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@
final class RestrictedStaticPropertyUsageRule implements Rule
{

/** @var RestrictedPropertyUsageExtension[] $extensions */
private ?array $extensions = null;

public function __construct(
private Container $container,
private ReflectionProvider $reflectionProvider,
Expand All @@ -44,8 +47,7 @@ public function processNode(Node $node, Scope $scope): array
return [];
}

/** @var RestrictedPropertyUsageExtension[] $extensions */
$extensions = $this->container->getServicesByTag(RestrictedPropertyUsageExtension::PROPERTY_EXTENSION_TAG);
$extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedPropertyUsageExtension::PROPERTY_EXTENSION_TAG);
if ($extensions === []) {
return [];
}
Expand Down
6 changes: 4 additions & 2 deletions src/Rules/RestrictedUsage/RestrictedUsageOfDeprecatedStringCastRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
final class RestrictedUsageOfDeprecatedStringCastRule implements Rule
{

/** @var RestrictedMethodUsageExtension[] $extensions */
private ?array $extensions = null;

public function __construct(
private Container $container,
private ReflectionProvider $reflectionProvider,
Expand All @@ -32,8 +35,7 @@ public function getNodeType(): string

public function processNode(Node $node, Scope $scope): array
{
/** @var RestrictedMethodUsageExtension[] $extensions */
$extensions = $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);
$extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);
if ($extensions === []) {
return [];
}
Expand Down
Loading