Fix SimplXmlElement and GMP casts

resources/functionMap.php

@@ -1650,7 +1650,7 @@
 'DomXsltStylesheet::result_dump_mem' => ['string', 'xmldoc'=>'DOMDocument'],
 'DOTNET::__construct' => ['void', 'assembly_name'=>'string', 'class_name'=>'string', 'codepage='=>'int'],
 'dotnet_load' => ['int', 'assembly_name'=>'string', 'datatype_name='=>'string', 'codepage='=>'int'],
-'doubleval' => ['float', 'var'=>'int|float|__stringNotStringable|bool|array|resource|null'],
+'doubleval' => ['float', 'var'=>'int|float|__stringNotStringable|bool|array|resource|GMP|SimpleXMLElement|null'],
 'Ds\Deque::__construct' => ['void', 'values='=>'mixed'],
 'Ds\Deque::count' => ['0|positive-int'],
 'Ds\Deque::jsonSerialize' => ['array'],
@@ -2448,7 +2448,7 @@
 'finfo_file' => ['string|false', 'finfo'=>'resource', 'file_name'=>'string', 'options='=>'int', 'context='=>'resource'],
 'finfo_open' => ['resource|false', 'options='=>'int', 'arg='=>'string'],
 'finfo_set_flags' => ['bool', 'finfo'=>'resource', 'options'=>'int'],
-'floatval' => ['float', 'var'=>'int|float|__stringNotStringable|bool|array|resource|null'],
+'floatval' => ['float', 'var'=>'int|float|__stringNotStringable|bool|array|resource|GMP|SimpleXMLElement|null'],
 'flock' => ['bool', 'fp'=>'resource', 'operation'=>'int-mask<LOCK_SH, LOCK_EX, LOCK_UN, LOCK_NB>', '&w_wouldblock='=>'0|1'],
 'floor' => ['__benevolent<float|false>', 'number'=>'float'],
 'flush' => ['void'],
@@ -5075,7 +5075,7 @@
 'intltz_to_date_time_zone' => ['DateTimeZone|false', 'obj'=>''],
 'intltz_use_daylight_time' => ['bool', 'obj'=>''],
 'intlz_create_default' => ['IntlTimeZone'],
-'intval' => ['int', 'var'=>'int|float|__stringNotStringable|bool|array|resource|null', 'base='=>'int'],
+'intval' => ['int', 'var'=>'int|float|__stringNotStringable|bool|array|resource|GMP|SimpleXMLElement|null', 'base='=>'int'],
 'InvalidArgumentException::__clone' => ['void'],
 'InvalidArgumentException::__construct' => ['void', 'message='=>'string', 'code='=>'int', 'previous='=>'(?Throwable)|(?InvalidArgumentException)'],
 'InvalidArgumentException::__toString' => ['string'],
@@ -10438,7 +10438,7 @@
 'strtoupper' => ['uppercase-string', 'str'=>'string'],
 'strtr' => ['string', 'str'=>'string', 'from'=>'string', 'to'=>'string'],
 'strtr\'1' => ['string', 'str'=>'string', 'replace_pairs'=>'array'],
-'strval' => ['string', 'var'=>'__stringAndStringable|int|float|bool|resource|null'],
+'strval' => ['string', 'var'=>'__stringAndStringable|int|float|bool|resource|GMP|null'],
 'substr' => ['__benevolent<string|false>', 'string'=>'string', 'start'=>'int', 'length='=>'int'],
 'substr_compare' => ['int<-1, 1>|false', 'main_str'=>'string', 'str'=>'string', 'offset'=>'int', 'length='=>'int', 'case_sensitivity='=>'bool'],
 'substr_count' => ['0|positive-int', 'haystack'=>'string', 'needle'=>'string', 'offset='=>'int', 'length='=>'int'],

src/Type/ObjectType.php

@@ -772,7 +772,10 @@
 
 	public function toInteger(): Type
 	{
-		if ($this->isInstanceOf('SimpleXMLElement')->yes()) {
+		if (
+			$this->isInstanceOf('SimpleXMLElement')->yes()
+			|| $this->isInstanceOf('GMP')->yes()
+		) {
 			return new IntegerType();
 		}
 
@@ -785,15 +788,21 @@
 
 	public function toFloat(): Type
 	{
-		if ($this->isInstanceOf('SimpleXMLElement')->yes()) {
+		if (
+			$this->isInstanceOf('SimpleXMLElement')->yes()
+			|| $this->isInstanceOf('GMP')->yes()
+		) {
 			return new FloatType();
 		}
 		return new ErrorType();
 	}
 
 	public function toString(): Type
 	{
-		if ($this->isInstanceOf('BcMath\Number')->yes()) {
+		if (
+			$this->isInstanceOf('BcMath\Number')->yes()
+			|| $this->isInstanceOf('GMP')->yes()
+		) {
 			return new IntersectionType([
 				new StringType(),
 				new AccessoryNumericStringType(),
@@ -910,6 +919,7 @@
 		if (
 			$this->isInstanceOf('SimpleXMLElement')->yes()
 			|| $this->isInstanceOf('BcMath\Number')->yes()
+			|| $this->isInstanceOf('GMP')->yes()
 		) {
 			return new BooleanType();
 		}

tests/PHPStan/Analyser/nsrt/bug-14136.php

@@ -0,0 +1,30 @@
+<?php
+
+namespace Bug14136Nsrt;
+
+use function PHPStan\Testing\assertType;
+
+$xml = <<<'EOT'
+<?xml version="1.0"?><item>3</item>
+EOT;
+
+$xml = simplexml_load_string($xml);
+assertType('int', intval($xml));
+assertType('int', intval(gmp_init(42)));
+assertType('int', (int) ($xml));
+assertType('int', (int) (gmp_init(42)));
+
+assertType('float', floatval($xml));
+assertType('float', floatval(gmp_init(42)));
+assertType('float', (float) ($xml));
+assertType('float', (float) (gmp_init(42)));
+
+assertType('string', strval($xml));
+assertType('non-empty-string&numeric-string', strval(gmp_init(42)));
+assertType('string', (string) ($xml));
+assertType('non-empty-string&numeric-string', (string) (gmp_init(42)));
+
+assertType('bool', boolval($xml));
+assertType('bool', boolval(gmp_init(0)));
+assertType('bool', (bool) ($xml));
+assertType('bool', (bool) (gmp_init(0)));

tests/PHPStan/Rules/Cast/InvalidCastRuleTest.php

@@ -72,6 +72,11 @@ public function testRuleWithNullsafeVariant(): void
 		]);
 	}
 
+	public function testBug14136(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-14136.php'], []);
+	}
+
 	public function testCastObjectToString(): void
 	{
 		$this->analyse([__DIR__ . '/data/cast-object-to-string.php'], [

tests/PHPStan/Rules/Cast/data/bug-14136.php

@@ -0,0 +1,28 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14136Cast;
+
+$xml = <<<'EOT'
+<?xml version="1.0"?><item>3</item>
+EOT;
+
+$xml = simplexml_load_string($xml);
+var_dump(intval($xml));
+var_dump(intval(gmp_init(42)));
+var_dump((int) ($xml));
+var_dump((int)(gmp_init(42)));
+
+var_dump(floatval ($xml));
+var_dump(floatval(gmp_init(42)));
+var_dump((float) ($xml));
+var_dump((float)(gmp_init(42)));
+
+var_dump(strval($xml));
+var_dump(strval(gmp_init(42)));
+var_dump((string) ($xml));
+var_dump((string)(gmp_init(42)));
+
+var_dump(boolval($xml));
+var_dump(boolval(gmp_init(42)));
+var_dump((bool) ($xml));
+var_dump((bool) (gmp_init(42)));

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

@@ -2481,39 +2481,39 @@ public function testBug6560(string $fileName): void
 
 		$this->analyse([__DIR__ . '/data/' . $fileName], [
 			[
-				sprintf('Parameter #1 %s of function strval expects bool|float|int|resource|string|null, array given.', $varName),
+				sprintf('Parameter #1 %s of function strval expects bool|float|GMP|int|resource|string|null, array given.', $varName),
 				23,
 			],
 			[
-				sprintf('Parameter #1 %s of function strval expects bool|float|int|resource|string|null, stdClass given.', $varName),
+				sprintf('Parameter #1 %s of function strval expects bool|float|GMP|int|resource|string|null, stdClass given.', $varName),
 				77,
 			],
 			[
-				sprintf('Parameter #1 %s of function intval expects array|bool|float|int|resource|string|null, stdClass given.', $varName),
+				sprintf('Parameter #1 %s of function intval expects array|bool|float|GMP|int|resource|SimpleXMLElement|string|null, stdClass given.', $varName),
 				80,
 			],
 			[
-				sprintf('Parameter #1 %s of function floatval expects array|bool|float|int|resource|string|null, stdClass given.', $varName),
+				sprintf('Parameter #1 %s of function floatval expects array|bool|float|GMP|int|resource|SimpleXMLElement|string|null, stdClass given.', $varName),
 				83,
 			],
 			[
-				sprintf('Parameter #1 %s of function intval expects array|bool|float|int|resource|string|null, %s@anonymous/tests/PHPStan/Rules/Functions/data/' . $fileName . ':13 given.', $varName, $stringableName),
+				sprintf('Parameter #1 %s of function intval expects array|bool|float|GMP|int|resource|SimpleXMLElement|string|null, %s@anonymous/tests/PHPStan/Rules/Functions/data/' . $fileName . ':13 given.', $varName, $stringableName),
 				89,
 			],
 			[
-				sprintf('Parameter #1 %s of function floatval expects array|bool|float|int|resource|string|null, %s@anonymous/tests/PHPStan/Rules/Functions/data/' . $fileName . ':13 given.', $varName, $stringableName),
+				sprintf('Parameter #1 %s of function floatval expects array|bool|float|GMP|int|resource|SimpleXMLElement|string|null, %s@anonymous/tests/PHPStan/Rules/Functions/data/' . $fileName . ':13 given.', $varName, $stringableName),
 				92,
 			],
 			[
-				sprintf('Parameter #1 %s of function strval expects bool|float|int|resource|string|null, mixed given.', $varName),
+				sprintf('Parameter #1 %s of function strval expects bool|float|GMP|int|resource|string|null, mixed given.', $varName),
 				95,
 			],
 			[
-				sprintf('Parameter #1 %s of function intval expects array|bool|float|int|resource|string|null, mixed given.', $varName),
+				sprintf('Parameter #1 %s of function intval expects array|bool|float|GMP|int|resource|SimpleXMLElement|string|null, mixed given.', $varName),
 				98,
 			],
 			[
-				sprintf('Parameter #1 %s of function floatval expects array|bool|float|int|resource|string|null, mixed given.', $varName),
+				sprintf('Parameter #1 %s of function floatval expects array|bool|float|GMP|int|resource|SimpleXMLElement|string|null, mixed given.', $varName),
 				101,
 			],
 		]);
@@ -2678,6 +2678,11 @@ public function testBug9652(): void
 		$this->analyse([__DIR__ . '/data/bug-9652.php'], []);
 	}
 
+	public function testBug14136(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-14136.php'], []);
+	}
+
 	#[RequiresPhp('>= 8.1')]
 	public function testBug8936(): void
 	{

tests/PHPStan/Rules/Functions/data/bug-14136.php

@@ -0,0 +1,28 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14136;
+
+$xml = <<<'EOT'
+<?xml version="1.0"?><item>3</item>
+EOT;
+
+$xml = simplexml_load_string($xml);
+var_dump(intval($xml));
+var_dump(intval(gmp_init(42)));
+var_dump((int) ($xml));
+var_dump((int)(gmp_init(42)));
+
+var_dump(floatval ($xml));
+var_dump(floatval(gmp_init(42)));
+var_dump((float) ($xml));
+var_dump((float)(gmp_init(42)));
+
+var_dump(strval($xml));
+var_dump(strval(gmp_init(42)));
+var_dump((string) ($xml));
+var_dump((string)(gmp_init(42)));
+
+var_dump(boolval($xml));
+var_dump(boolval(gmp_init(42)));
+var_dump((bool) ($xml));
+var_dump((bool) (gmp_init(42)));