Assert ExprCacheHelper->import() will not mix up same expr-string based attributes#5023
Merged
ondrejmirtes merged 3 commits intophpstan:2.1.xfrom Feb 22, 2026
Merged
Conversation
Collaborator
|
This pull request has been marked as ready for review. |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test when attributes which represent the same value expression don't inherit data from a previous call to
ExprCacheHelper::import()because of a poisened cache in the underlyingCachedParser.this test makes sure we don't regress after starting to re-use the
CachedParserin ondrejmirtes/BetterReflection#41.with this PR in place, we can be sure that we don't get back the bug which was fixed by ondrejmirtes/BetterReflection@e124747 when reverting said commit.