-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Pr android choose media #2756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ditingvh
wants to merge
262
commits into
pichillilorenzo:v6.1.5
Choose a base branch
from
ditingvh:pr-android-chooseMedia
base: v6.1.5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Pr android choose media #2756
ditingvh
wants to merge
262
commits into
pichillilorenzo:v6.1.5
from
ditingvh:pr-android-chooseMedia
+63,514
−13,494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ributors/add-nnnlog add nnnlog as a contributor for code
…ributors/add-Murmurl912 add Murmurl912 as a contributor for code
[web] support iframe role and aria-hidden attributes
…ributors/add-bschulz87 add bschulz87 as a contributor for ideas
…n data server callback pichillilorenzo#2188
…ssue-1983 issue pichillilorenzo#1983: Fixed to prevent Activity from being restored
…ributors/add-ShuheiSuzuki-07 add ShuheiSuzuki-07 as a contributor for code
…_main on release mode, updated android activities restore from savedInstanceState
… pluginScriptsForMainFrameOnly InAppWebViewSettings parameters, Added setJavaScriptBridgeName, getJavaScriptBridgeName static WebView controller methods, Added JavaScriptHandlerFunctionData type, Deprecated JavaScriptHandlerCallback type in favor of JavaScriptHandlerFunction type, android: Added support for UserScript.forMainFrameOnly parameter, Updated UserScript at document end implementation
…ce, Added support for UserScript.allowedOriginRules parameter
…face, Added support for UserScript.allowedOriginRules parameter
…ace 1.4.0, Updated scrollMultiplier default value from 6 to 1, Added support for UserScript.allowedOriginRules and UserScript.forMainFrameOnly parameters, Fixed get_optional_fl_map_value implementation in utils/flutter.h
…ridgeOriginAllowList, javaScriptBridgeForMainFrameOnly, javaScriptHandlersForMainFrameOnly
…llowList, javaScriptBridgeForMainFrameOnly, javaScriptHandlersForMainFrameOnly
fix pichillilorenzo#2484, Remove not-empty assert for Cookie.value
…ributors/add-laishere add laishere as a contributor for code
…prevent-gesture-delay Fix gesture recognition delay prevention for latest Flutter versions
…ributors/add-muccy-timeware add muccy-timeware as a contributor for code
Prevent Unpredictable Close On Windows
…ributors/add-momadvisor add momadvisor as a contributor for code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
android
documentation
iOS
linux
Linux platform
macOS
macOS platform
platform_interface
Platform Interface
plugin
flutter_inappwebview plugin
web
windows
Windows platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection with issue(s)
Resolve issue #2146
Connected to #2146
Testing and Review Notes
1.InAppWebView(
...
onShowFileChooserAndroid: (controller, type) {
return c.onShowFileChooserAndroid(
controller, type, widget.url);
},
...
)
2.about func 'onShowFileChooserAndroid' like this(
wechat_assets_picker: ^9.8.0):
Future onShowFileChooserAndroid(
controller, type, String url) async {
debugPrint('onShowFileChooserAndroid is running:$type');
List list = [];
try {
bool isAndroid = Platform.isAndroid;
final List? result = await AssetPicker.pickAssets(context);
if (result != null) {
for (int i = 0; i < result.length; i++) {
var file = await result[i].file;
if (file != null) {
list.add(file.path);
}
}
}
return list;
} catch (e) {
debugPrint("error = $e");
return [];
}
}
3.click "<input" tag in webview on Android platfom
Screenshots or Videos
To Do
must return value,even if a empty List,please
InAppWebView(
...
onShowFileChooserAndroid: (controller, type) {
return c.onShowFileChooserAndroid(
controller, type, widget.url);
},