Code Example was not compatible with new Twig version 3#68
Open
dipohl wants to merge 1 commit intopicocms:masterfrom
Open
Code Example was not compatible with new Twig version 3#68dipohl wants to merge 1 commit intopicocms:masterfrom
dipohl wants to merge 1 commit intopicocms:masterfrom
Conversation
Collaborator
|
Thank you for your contribution! 👍 However, that's because the docs reference Pico 2.1, not the dev version of Pico 3.0. See #61, it was fixed there already. Thanks nevertheless! |
Author
I suppose the updated syntax example will work under both Twig versions, so you can change it anyhow. As Docs for Pico 3.0 are not shown on the website (at least I didn't see / find it there) I strongly vote for it. Otherwise all users of the new version will get frustrated with the incompatible advice.. |
7d00492 to
20ba8c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under Pico-30: PHP message: PHP Fatal error: Uncaught Twig\Error\SyntaxError: Unexpected token "name" of value "if" ("end of statement block" expected).