Fix a bug hydrating from worker pool cache #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lol whoopsies, classic lil order of operations shenanery.
amadeus
force-pushed
the
amadeus/fix-worker-cache-bug
branch
from
be074ff to
a568cbe
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes a cache hydration bug in the worker pool implementation where render options were being evaluated before the render cache was populated, causing unnecessary re-renders even when valid cached results existed.
- Reordered cache population to occur before
getRenderOptionscall, allowing proper cache detection - Simplified the fallback renderCache initialization logic
- Applied the same fix pattern to both
FileRendererandDiffHunksRenderer
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/diffs/src/renderers/FileRenderer.ts | Fixed cache hydration order in renderFile method to prevent false positive forceRender triggers |
| packages/diffs/src/renderers/DiffHunksRenderer.ts | Fixed cache hydration order in renderDiff method with identical pattern as FileRenderer |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lol whoopsies, classic lil order of operations shenanery.
Basically the bug was that because we were populating the renderCache AFTER we made a call to
getRenderOptions, which in turn would returnforceRender: trueif renderCache was empty.So the fix here is to fix here is to attempt to create renderCache from cache if it exists, then allow the forceRender to compute its thing if necessary.