Skip to content

Comments

Add setCustomProperties method to CartItemInterface#146

Closed
dblaichinger wants to merge 13 commits intopimcore:2.xfrom
dblaichinger:add-setCustomProperties-to-CartItemInterface
Closed

Add setCustomProperties method to CartItemInterface#146
dblaichinger wants to merge 13 commits intopimcore:2.xfrom
dblaichinger:add-setCustomProperties-to-CartItemInterface

Conversation

@dblaichinger
Copy link

Overview

In order to avoid BC-BREAK in #143, the extension of CartItemInterface was removed there. See: #143 (comment)

This pull request will extend the CartItemInterface again, as the method setCustomProperties should be defined there.
Please add label BC-BREAK here and consider it when creating next major release.

Thank you!

Daniel Blaichinger and others added 10 commits December 14, 2023 09:27
…chinger/ecommerce-framework-bundle into add-custom-properties-to-cart-item
Co-authored-by: Sebastian Blank <sebastian.bl@gmx.de>
…chinger/ecommerce-framework-bundle into add-custom-properties-to-cart-item
…chinger/ecommerce-framework-bundle into add-custom-properties-to-cart-item
…chinger/ecommerce-framework-bundle into add-custom-properties-to-cart-item
…chinger/ecommerce-framework-bundle into add-custom-properties-to-cart-item
@dblaichinger
Copy link
Author

Hi @fashxp,

just wanted to check back regarding #143 (comment).

Do you suggest to add a new field params and add it to \CartManager\CartItem\Dao::$fieldsToSave to be saved automatically?

Thanks,
Daniel

@fashxp
Copy link
Member

fashxp commented Apr 15, 2024

@dblaichinger sorry for not coming back earlier, I missed that comment :(

yes, I was thinking of saving this additional data automatically. Not sure, what is necessary for that all though out of my head ... probably depends on the cart implementation, as the db cart will need some additional database table and some strategy to save this data (e.g. as json or something similar).

@ghost ghost added the Pimcore:ToDo label Jul 16, 2024
@ghost ghost added Pimcore:Priority and removed Pimcore:ToDo labels Aug 20, 2024
@mattamon mattamon changed the base branch from 1.x to 2.x October 23, 2024 11:32
@fashxp fashxp modified the milestones: 2.0.0, 3.0.0 Apr 18, 2025
@kingjia90

This comment was marked as resolved.

@kingjia90 kingjia90 self-assigned this Jun 2, 2025
@kingjia90
Copy link
Contributor

kingjia90 commented Jun 2, 2025

Could you please also add an entry about this interface change on https://github.com/pimcore/ecommerce-framework-bundle/blob/2.x/doc/19_Upgrade_Notes/README.md under 3.0.0? TIA

@github-actions
Copy link

github-actions bot commented Jun 4, 2025

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (kingjia90)[https://github.com/kingjia90]
@daniel Blaichinger
Daniel Blaichinger seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@kingjia90 kingjia90 force-pushed the add-setCustomProperties-to-CartItemInterface branch from 1355cbb to a3fae64 Compare June 10, 2025 13:07
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4 New Major Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@kingjia90 kingjia90 closed this Jun 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2025
@fashxp fashxp removed this from the 3.0.0 milestone Jul 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants