Add setCustomProperties method to CartItemInterface#146
Add setCustomProperties method to CartItemInterface#146dblaichinger wants to merge 13 commits intopimcore:2.xfrom
Conversation
…use $params in Cart::addItem
…use $params in Cart::addItem
…chinger/ecommerce-framework-bundle into add-custom-properties-to-cart-item
Co-authored-by: Sebastian Blank <sebastian.bl@gmx.de>
…chinger/ecommerce-framework-bundle into add-custom-properties-to-cart-item
…chinger/ecommerce-framework-bundle into add-custom-properties-to-cart-item
…chinger/ecommerce-framework-bundle into add-custom-properties-to-cart-item
…chinger/ecommerce-framework-bundle into add-custom-properties-to-cart-item
…d $params variable
|
Hi @fashxp, just wanted to check back regarding #143 (comment). Do you suggest to add a new field Thanks, |
|
@dblaichinger sorry for not coming back earlier, I missed that comment :( yes, I was thinking of saving this additional data automatically. Not sure, what is necessary for that all though out of my head ... probably depends on the cart implementation, as the db cart will need some additional database table and some strategy to save this data (e.g. as json or something similar). |
This comment was marked as resolved.
This comment was marked as resolved.
|
Could you please also add an entry about this interface change on https://github.com/pimcore/ecommerce-framework-bundle/blob/2.x/doc/19_Upgrade_Notes/README.md under |
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
1355cbb to
a3fae64
Compare
|




Overview
In order to avoid
BC-BREAKin #143, the extension ofCartItemInterfacewas removed there. See: #143 (comment)This pull request will extend the
CartItemInterfaceagain, as the methodsetCustomPropertiesshould be defined there.Please add label
BC-BREAKhere and consider it when creating next major release.Thank you!