[Improvement]: Distinguish relation conditions applied as preconditions#249
Merged
kingjia90 merged 7 commits intopimcore:2.xfrom Jun 12, 2025
Conversation
dolmit-tanel-paaro
force-pushed
the
distinguish-relation-conditions-applied-as-preconditions
branch
3 times, most recently
from
fafe916 to
9b70410
Compare
Contributor
Author
|
I'm not sure if we also should update filters in Findologic and SearchIndex namespaces. |
Contributor
Author
Updated those classes too. |
dolmit-tanel-paaro
force-pushed
the
distinguish-relation-conditions-applied-as-preconditions
branch
from
92e3083 to
84fb3a3
Compare
|
ghost
added
the
kingjia90
requested changes
May 27, 2025
dolmit-tanel-paaro
force-pushed
the
distinguish-relation-conditions-applied-as-preconditions
branch
from
63ac52a to
da0d776
Compare
dolmit-tanel-paaro
force-pushed
the
distinguish-relation-conditions-applied-as-preconditions
branch
from
da0d776 to
666bfe6
Compare
kingjia90
requested changes
May 28, 2025
kingjia90
reviewed
May 30, 2025
Contributor
Author
|
@kingjia90 Pushed a fix for the situation you're stuck in. |
dolmit-tanel-paaro
force-pushed
the
distinguish-relation-conditions-applied-as-preconditions
branch
from
33fe854 to
f45d3c8
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #248