Draft
Conversation
TODO write tests for all INCs
perhaps a bit too thouroughly for such a simple instruction that doesn't touch any flag. 120 tests, 0.12 seconds
Test INC r16
Console + code viewer + fixes
which in turn is copied (?) back to ppu.tilemap: VRamContents (?) is copy elision a thing with VRamContents::load(&[u8]) -> VRamContents? Should we have a VRamContents::load(&self, &[u8]) instead? btw I renamed `consumer` to `reader` because I read bits of egui's source code which use the same pattern and call it `reader`, and I thought `consumer` wasn't the most accurate name.
move code listing to array
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm playing with the
Dereftraits and stuff. Mostly trying to get some of Rust's borrowing semantics.This has that stack overflow problem until I rebase on @joajfreitas's recent changes, but I want to try something different...
like writing a separate constructor for
Busthat uses MaybeUninit just to avoid stack overflow in debug builds (and tests).