Added additional stochastic models[finished]#1432
Merged
Conversation
…into i-96-abc-routine
…into i-96-abc-routine
Codecov Report
@@ Coverage Diff @@
## master #1432 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 90 92 +2
Lines 8971 8968 -3
=========================================
- Hits 8971 8968 -3
Continue to review full report at Codecov.
|
Contributor
Author
|
This PR is ready for a review. As in #1413, some unit tests are failing, however, I think this is not because of this PR. |
ben18785
approved these changes
Mar 15, 2022
Collaborator
ben18785
left a comment
There was a problem hiding this comment.
Looks great! Thanks @phumtutum I've made a few cosmetic changes to the notebooks, but otherwise I'm happy for this to go in.
MichaelClerx
approved these changes
Mar 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1417 added MarkovJumpModels which can be used to add stochastic models more easily. This PR: