-
Notifications
You must be signed in to change notification settings - Fork 177
Add Cookie extension with unit test and fuzzing #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #770 +/- ##
==========================================
- Coverage 81.45% 81.44% -0.02%
==========================================
Files 102 103 +1
Lines 5689 5717 +28
==========================================
+ Hits 4634 4656 +22
- Misses 679 682 +3
- Partials 376 379 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoTurk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make a branch for dtls 1.3? I'm just worried we might break something for dtls 1.2 or if we want to make a release for dtls 1.2. cherry-picking commits might be hard after few months.
I know we talked about this before but we merged few bug fixes and enhancements since then.
Up to you. I'm just suggesting :)
|
I am excited/curious to see how we do 1.2 and 1.3 in the code base at the same time? @theodorsm Do you think you will share code between them, or will be a clear line in the code base? Do you think the code base will end up in a state where we can't make a release (but have a urgent 1.2 bug?) |
faf7788 to
0b2733f
Compare
|
@Sean-Der, @JoTurk Adding extension parsers shouldn't affect DTLS 1.2. I think it makes sense to have them in the master branch already. For more involved stuff we have to re-visit #738 (let's have a discussion about it there). crypto/tls implements all extensions side by side for tls 1.2 and tls 1.3 |
|
Also, fuzzing might be a bit overkill for this simple extension, but I think all unmarshalling of raw bytes should be fuzzed and this sets an easy example. |
|
@JoTurk, thanks for the feedback! Should be fixed now. |
JoTurk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your fast fixes.
Description
DTLS 1.3 has moved it's cookie handling to an extension.
Reference issue
Fixes #769