Apply go modernize

[tmatth]

Applied with

go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test *.go

N.B. ranging over constants requires go >= 1.22 and testing.Loop requires go1.24 or later.

[JoTurk]

We can't bump go version now :(
Maybe we should do it after 4.3.

[tmatth]

Yeah I was wondering about that. Marking as blocked for now.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.58%. Comparing base (1edc72d) to head (d98a350).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #351   +/-   ##
=======================================
  Coverage   82.58%   82.58%           
=======================================
  Files          28       28           
  Lines        3428     3428           
=======================================
  Hits         2831     2831           
  Misses        427      427           
  Partials      170      170           

Flag	Coverage Δ
go	82.58% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Sean-Der]

Nice changes @tmatth

Worth adding to ci? Could we use an older version of the tool that doesn't to an upgrade?

[JoTurk]

@Sean-Der we can use it with golangci-lint, but last time i checked, it cased some conflicts with some linters (gosec?), also i'll check how to set it so it doesn't try to force us to update Go version, I'm going to check again after the fact we upgraded golangci-lint to 2.6.

[JoTurk]

https://golangci-lint.run/docs/linters/configuration/#modernize

[Sean-Der]

Oh that's nice @JoTurk it's pretty wild how much 'Good Go Code' has changed.

Especially in pion/turn it feels like a time portal :)