Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request merges the master branch into the client_integration branch to update the pwar version and integrate PixelAW–specific pages and configurations for the client application. Key changes include the revision of index.html with updated meta tags and inline scripts, removal of legacy linting/dojo configuration files in favor of new configuration (biome.json), and significant documentation and build/deployment updates across several files.
Reviewed Changes
Copilot reviewed 204 out of 204 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| client/index.html | Updated meta tags, favicon link, and added inline touch event handling with debug logging. |
| client/eslint.config.js | Removed in favor of the new configuration approach. |
| client/dojoConfig.ts | Removed as part of the refactor. |
| client/docker-compose.yml | Added new Docker Compose configuration for PixelAW core with version 0.6.31. |
| client/doc/* | Added diagram and PNG generation script files. |
| client/components.json | Removed legacy component configuration. |
| client/biome.json | Added new linting and formatting configuration. |
| client/VERSION | Added new version file (0.7.3). |
| client/README.md | Updated instructions and renamed header to "Vanilla Pixelaw". |
| client/Makefile | Added Makefile for Docker image build. |
| client/Dockerfile | Introduced a multi-stage Dockerfile with different stages for dependencies, build, and production. |
| client/.vscode/* | Removed VS Code extension recommendations. |
| client/.prettierrc.mjs | Removed in favor of unified formatting configuration. |
| client/.gitignore | Removed the file; ensure ignored patterns are maintained elsewhere. |
| client/.env.example | Updated host addresses from localhost to 127.0.0.1. |
| client/.cursorrules | Removed internal coding guideline file. |
| README.md | Revised root documentation with updated setup and build instructions. |
Comments suppressed due to low confidence (1)
client/.gitignore:1
- Verify that the removal of client/.gitignore is intentional and that the necessary ignore patterns are maintained elsewhere to prevent accidental commits of build artifacts and logs.
# Entire file removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge master branch into client_integration working branch for the most of up-to-date pwar version.
This PR:
Fixes all linting and formatting errors.
Note: Pwar is still a work in progress and this repo is not yet ready for a final launch.